Ticket #7975 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

EQSANS: fix issue with transmission correction in frame skipping

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.0
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The corrected workspace output property is not correctly set in EQSANSDirectBeamTransmission.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #7975 Fix corrected output

Changeset: 887c17b5c3333019a8c104d90a084c5198fab793

comment:2 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Perform an EQSANS reduction that uses background. The runs must have been taken in frame-skipping mode (run 3293 from the system tests).

  • Check that the reduction completes. It used to crash at the background transmission calculation.

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:4 Changed 7 years ago by Mathieu Doucet

Re #7975 Fix another mixup

Changeset: b9ed4279835613bd3988544fed10a175748d3264

comment:5 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to inprogress

Re #7975 add ref data for correct frame

Changeset: d0a0aae689640d109951c02e7bebdec31e1655f9

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

Should now work and all system tests should pass.

Note that one system test has changed to accommodate the fix. Please merge the changes to the system tests onto master.

The system tests branch is ​feature/7975_eqsans_transmission_fix

comment:8 Changed 7 years ago by Mathieu Doucet

Re #7975 Turn off instr. conf. in test

Changeset: fb5408f362c83499bff1c0e53f2538b3e60f884c

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/7975_eqsans_transmission_fix'

comment:10 Changed 7 years ago by Michael Reuter

Merge remote-tracking branch 'origin/feature/7975_eqsans_transmission_fix'

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Framework to SANS

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8820

Note: See TracTickets for help on using tickets.