Ticket #7977 (closed: fixed)
[IDA] Add sample logs to Elwin
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | |
Blocking: | Tester: | Peter Parker |
Description
Update Elwin to Add some useful sample logs to the output workspace(s). Modifications are in the supplied file:
There are a couple of new lines at 262 & 265 Then all the AddSampleLog section is in 370-400 with some other lines moved : 345-6, 351-4, 358-60.
Attachments
Change History
Changed 7 years ago by Samuel Jackson
- Attachment IndirectDataAnalysis.py added
comment:1 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #7977 Added sample logs to Elwin.
Changeset: 67fa6987523bfad14f215057343cf5296c14a220
comment:2 Changed 7 years ago by Samuel Jackson
Refs #7977 Changing logs floating point logs to be numeric.
Changeset: 52e847f00c7fce5b2433a255a810ea78413bfb31
comment:3 Changed 7 years ago by Samuel Jackson
Refs #7977 Missed converting a log from string to number
Changeset: 1e1edf93a0076672a2a5b0b46b4a092f3672267a
comment:4 Changed 7 years ago by Samuel Jackson
To Tester
Verify that Elwin still works and that each of the three output files contain the following sample logs:
- Vaxis - A Label for the axis
- Range1 start - start of the first range
- Range1 end - end of the first range
- Two ranges - Boolean defining if two ranges were used
if two ranges were used the following logs should also be present:
- Range2 start - start of the first range
- Range2 end - end of the first range
Additonally, on the EW1 workspace the following logs should appear:
- Temperature normalise
- Temperature value - (only if the temp was normalised)
comment:5 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:7 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #7977 Swapped temp value to be correct.
Changeset: 9e27526387bc308ea9df59e59ad16e9c14693124
comment:8 Changed 7 years ago by Samuel Jackson
Refs #7977 Fix for broken system test.
Changeset: ae8be47fa0c630d899518d70987aad2ca74b70a5
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:12 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution fixed deleted
The temperature normalise/value logs don't appear in the *_eq1 workspace. Changeset: 52e847f00c7fce5b2433a255a810ea78413bfb31 ended up removing the code responsible for those entries.
I'm not sure if that was intentional, but since you asked that those values be tested I'll reopen the ticket.
Changed 7 years ago by Samuel Jackson
- Attachment irs55131_graphite002_red.nxs added
Example file for testing.
Changed 7 years ago by Samuel Jackson
- Attachment irs55131_graphite002_red.2.nxs added
Example file for testing.
comment:13 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
As discussed the logs weren't removed but I forgot to mention that the temp logs will only appear if the nexus file has temperature information available. Use the supplied file (not sure why trac added it twice, they're both the same) and check "normalise to lowest temp" and the missing logs should appear.
comment:15 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7977_add_sample_logs_to_elwin'
Full changeset: c64442a5d5ef418b7ceede29413384bd5ed6cb00
comment:16 Changed 7 years ago by Peter Parker
Works with that file. Code looks good. Passing.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8822
IDA python script with updated Elwin functions