Ticket #7998 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

IDF for Larmor

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

Insert IDF for Larmor

Attachments

LARMOR_Definition.xml (11.8 KB) - added by Gesner Passos 7 years ago.

Change History

Changed 7 years ago by Gesner Passos

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

Inclusion of Larmor IDF file

re #7998

Changeset: 3434febcf2c1d3565f057603e10a8cadbb838013

comment:2 Changed 7 years ago by Gesner Passos

Add Larmor to Facilities.xml

re #7998

Changeset: 07c42ecdbcf6a75089a9f3396e0f2a39ead2b7f2

comment:3 Changed 7 years ago by Gesner Passos

Correct the dates for Larmor IDF

re #7998

Changeset: d662d449773434a082f0d13bcbe1eee16e1245ec

comment:4 Changed 7 years ago by Gesner Passos

Add Larmor Parameters file

It includes the parameter that tells Mantid to load the detectors positions (parameter map) form the Nexus file.

re #7998

Changeset: d6f1eed47eb8e48287022516ff3a00071dc6e50c

comment:5 Changed 7 years ago by Gesner Passos

Update FacilityInfoTest to consider LARMOR

re #7998

Changeset: 91e74691733c3bd57cec31b5d9fb53003abc056b

comment:6 Changed 7 years ago by Gesner Passos

I'm waiting for the answer of Robert to see if I can publish this as it is? (It does not allow loading 'old' files (larmorxx10.nxs) because it does not have calibration information inside.

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

There is one more commit that seems not to be appearing here, but I have reverted the commit in comment:4. We will not ship this parameter file. It has no reason to do it.

Tester:

The larmor files are in ndxlarmor. There are 14 files. You may open a couple of them.

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:9 Changed 7 years ago by Jay Rainey

I verified that the changes made to Facilities.xml and FacilityInfoTest was correct. I ran the unit tests on my machine (Ubuntu 12.04) to ensure the modified unit test passed, and that there was no problems caused indirectly.

comment:10 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7998_larmor_idf'

Full changeset: 6afac77e4266b9c65905ced42b315afc16543fe6

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8843

Note: See TracTickets for help on using tickets.