Ticket #8003 (closed: fixed)
DetectorDotDat File wrong specification
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
It seems that the Number_of_user_table_parameters is wrong in Mantid.
The number of columns is always 5 + Number_of_user_table_parameters.
While, we are using Number_of_user_table_parameters as Number of columns.
Attachments
Change History
comment:2 Changed 7 years ago by Gesner Passos
Correct the interpretation of DetectorDotDatFile
The Number of columns in a detector.dat file is 5 plus the number of user table parameters. This commit correct this information.
re #8003
Changeset: 7c2ec2688a3a860cf06344210dc0e154792f2505
comment:3 Changed 7 years ago by Gesner Passos
Tester:
The three dotdat files are valid ones. This script should work for all of them.
ws = Load('MAP17186.raw')
ModifyDetectorDotDatFile(ws,'detector.dat','/tmp/test1.dat')
ModifyDetectorDotDatFile(ws,'detector_con_phi.dat','/tmp/test2.dat')
ModifyDetectorDotDatFile(ws,'detector_complete.dat','/tmp/test3.dat')
comment:4 Changed 7 years ago by Gesner Passos
Correct the incorrect assumption of detectordotdat file
Although present almost always, according to the control group, the phi column is the first of the User optional column. So, we can not suppose it is there.
re #8003
Changeset: 3350f9ad6cffcdd58fb2115e1d97d93a7598fe8e
comment:5 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:7 Changed 7 years ago by Gesner Passos
Correct the interpretation of DetectorDotDatFile
The Number of columns in a detector.dat file is 5 plus the number of user table parameters. This commit correct this information.
re #8003
Changeset: 7259e7be498b25cf2582e962af150ebe6b08a854
comment:8 Changed 7 years ago by Gesner Passos
Correct the incorrect assumption of detectordotdat file
Although present almost always, according to the control group, the phi column is the first of the User optional column. So, we can not suppose it is there.
re #8003
Changeset: 515fc40c000a4b62f2f2e528bff1336190932cd0
comment:9 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
It seems that Wenduo Zhou has tested this ticket and passed it (pushed to master) without accepting it for verification. I also tested it with the provided and script and it passes.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8848
