Ticket #8009 (closed: fixed)
Update BASIS geometry to include diffraction
| Reported by: | Stuart Campbell | Owned by: | Stuart Campbell |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Andrei Savici |
Description
We need to add the diffraction geometry for the BASIS elastic detectors.
Change History
comment:2 Changed 7 years ago by Stuart Campbell
Added diffraction banks to BASIS IDF. refs #8009
Changeset: e0af55de25a41450778b007940d6884b1f4c5b81
comment:3 Changed 7 years ago by Stuart Campbell
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Stuart Campbell
Mask out diffraction banks. refs #8009
Changeset: ab51b86965172d905ac1f59eb3ecc9fdfa163c9d
comment:5 Changed 7 years ago by Stuart Campbell
removed diffraction banks to fix systemtests - refs #8009
Changeset: 040759812d1ba823f123ccad10b740c16b526ecc
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
The BASISReduction system test is still failing.
comment:7 Changed 7 years ago by Stuart Campbell
- Status changed from reopened to inprogress
Change mask file that is actually used by the systemtests.
refs #8009
Changeset: c8e33993aecfd270b19e9a4279adc1a9fef019d2
comment:8 Changed 7 years ago by Russell Taylor
I merged the tip of the branch into develop (for the mantid repo) so that we can hopefully have passing builds for testing day. The last 2 commits had not been merged.
comment:10 Changed 7 years ago by Stuart Campbell
Added Parameter files for BASIS diffraction
refs #8009
Changeset: c01676589d155799bc1d5b2ccebdc1da52bebb10
comment:11 Changed 7 years ago by Stuart Campbell
Updated BASIS IDF. refs #8009
Changeset: c00f3caf68740a726b80beeeef626ce37ab3122b
comment:12 Changed 7 years ago by Stuart Campbell
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Stuart Campbell
TESTER:
Branch name - feature/8009_basis_diffraction_idf
The first thing is that LoadEmptyInstrument works and displays a sensible looking instrument.
If you load a file that has data in the diffraction detector and specify an entry name of entry-diff then you should see data in the diffraction bank - otherwise (if you don't specify entry-diff) you will see data in the inelastic bank and not the diffraction.
A good BASIS run is 29519.
comment:14 Changed 7 years ago by Stuart Campbell
Added old IDF back for historical runs. refs #8009
Changeset: 2126b8dddbc2e5fb36d9006ac81ae81c44cab8ee
comment:15 Changed 7 years ago by Stuart Campbell
Mask using detector ids.
This is to get around a bug with LoadMask/LoadInstrument that always seems to load the newest IDF, which is the wrong one in this case.
refs #8009
Changeset: 607c187e54a1df44957de79597bfc700f3b7a908
comment:16 Changed 7 years ago by Stuart Campbell
Fixed validation errors. refs #8009
Changeset: b7fc43c0ed797fee5844df285952e2b5c1b005a9
comment:17 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:18 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8009_basis_diffraction_idf'
Full changeset: 07e8274b66586c028e0fb7a5b732c614a3fbc195
comment:19 Changed 7 years ago by Andrei Savici
Merge remote-tracking branch 'origin/feature/8009_basis_diffraction_idf'
Full changeset: ee34afd5c711fd2a79e27719be88b3fc5fde2a53
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8854
