Ticket #8010 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

OSIRIS Diffraction workspace average bug.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

Running an OSIRIS diffraction with certain inputs causes the following error. 

RuntimeError: unsupported operand type(s) for /=: 'str' and 'int'
  at line 182 in '/home/chs18285/git/mantid-testing/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/OSIRISDiffractionReduction.py'
  caused by line 209 in '/home/chs18285/git/mantid-testing/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/OSIRISDiffractionReduction.py'
  caused by line 88 in '/home/chs18285/git/mantid-testing/Code/Mantid/Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/OSIRISDiffractionReduction.py'
  at line 5 in 'New script'
  caused by line 547 in '/home/chs18285/git/mantid-testing/Code/debug/bin/mantid/simpleapi.py'

The issue can be reproduced using the following script: 

from mantid.simpleapi import OSIRISDiffractionReduction
OSIRISDiffractionReduction(
OutputWorkspace="OsirisDiffractionTest",
Sample="osiris00102567.raw, osiris00102568.raw",
CalFile="osiris_041_RES10.cal", Vanadium="osiris00102567.raw, osiris00102568.raw")

Attachments

osiris00102542.raw​ (3.7 MB) - added by Samuel Jackson 7 years ago.
osiris00102543.raw​ (2.1 MB) - added by Samuel Jackson 7 years ago.
osiris00102544.raw​ (1.5 MB) - added by Samuel Jackson 7 years ago.
osiris00102545.raw​ (1.2 MB) - added by Samuel Jackson 7 years ago.
osiris00102567.raw​ (1.5 MB) - added by Samuel Jackson 7 years ago.
osiris00102568.raw​ (1.5 MB) - added by Samuel Jackson 7 years ago.
osiris_041_RES10.cal​ (34.9 KB) - added by Samuel Jackson 7 years ago.
test_OSI_diffraction.py​ (293 bytes) - added by Samuel Jackson 7 years ago.
Testing script

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8010 Fixed workspace averaging.

Changeset: 90cc8dcf5bc7cd9f9f28432b75d2ec0b005c4f46

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Changed 7 years ago by Samuel Jackson

Testing script

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

I've attached the files that Franz was using that caused the error to occur along with a python script which is based on the current system test for OSIRIS diffraction.

Test that you can reproduce the error and use the testing data/script to check that the issue is resolved and that the code changes are appropriate.

comment:3 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8010_osi_diffraction_bug'

Full changeset: ​cdd97fee9a95680857a967cb149cdcff2ed487d4

comment:5 Changed 7 years ago by Jay Rainey

Error no longer occurs. I used various inputs, including the script and files provided. Tested on Ubuntu 12.04.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8855

Note: See TracTickets for help on using tickets.