Ticket #8019 (closed: fixed)
SNSPowderReduction generates Fullprof file with negative uncertainty
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Diffraction | Keywords: | |
Cc: | petersonpf@… | Blocked By: | |
Blocking: | Tester: | Peter Peterson |
Description
For NOMAD, with this setup: sam_back = 18251 van = 18250 van_back = 18249 Fullprof data file reduced from Run 18251 has negative uncertainty. This should be fixed.
Some initial investigation shows that before being divided by a negative (obviously wrong) vanadium spectrum, the uncertainty of the focused data was still positive.
Attachments
Change History
comment:2 Changed 7 years ago by Wenduo Zhou
Fixed the bug due to lack of fabs. Refs #8019.
Changeset: 0d69a0e5af2d87114bb2fe41c603d47cba7726f0
comment:3 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
Instruction to verify the ticket
- Download 'verify8019.py'
- Build Mantid and run the python script; You should find that in workspace 'NOM_18251', the uncertainty is negative;
- Merge the change in this ticket to master and build Mantid
- Run the script again, then you will find that the uncertainties in 'NOM_18251' is positive.
comment:4 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
You need to remove your debugging printouts.
comment:5 Changed 7 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Cleaned the debug output. Refs #8019.
Changeset: a0e710e5b23adc0b61958f2950b6294e399a556d
comment:6 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:9 Changed 7 years ago by Peter Peterson
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8019_fix_neg_uncertainty'
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8864