Ticket #8023 (closed: fixed)
Add ConvertToMD::validateInputs()
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description
This is more for giving reasonable error messages to the user than anything else. At the moment the big one is assuring that MinValues and MaxValues are of the sensible lengths for the units selected and that the individual maxes are bigger than the individual mins.
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
Re #8023. Moving code from header to source.
Changeset: 4a324a236a7a744a378012adc2c30d491acf6263
comment:3 Changed 7 years ago by Peter Peterson
Re #8023. Adding checks for MinValues and Maxvalues.
Changeset: 907bdd4eb481cc9195067b1374d09026ce4ffa64
comment:4 Changed 7 years ago by Peter Peterson
Re #8023. Changing test to look for exceptions.
Changeset: af06ec6ffb0fc0e1d94bff9aa6a920df38a015d1
comment:5 Changed 7 years ago by Peter Peterson
Merge branch 'feature/8023_converttomd_validateinputs' into develop
Conflicts:
Code/Mantid/Framework/MDAlgorithms/test/ConvertToQ3DdETest.h
Re #8023
Changeset: 3567bb92df5185da3c9a00772bf7e2fb1f4ecafd
comment:6 Changed 7 years ago by Peter Peterson
Re #8023 and #7529. commenting out conflicting test branches.
Changeset: 619f24ff52fb781a7702801309dcadafbe8edfb2
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/8023_converttomd_validateinputs.
Andrei told me to push this. The changeset is more likely the way to test it. The last two commits were merge conflicts as this has direct competition from #7529.
comment:8 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:9 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8023_converttomd_validateinputs'
Full changeset: dfe7bc31e0926ccccbed22f6687856eb7f47a4e4
comment:10 Changed 7 years ago by Andrei Savici
verified #min!=#max and min>max
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8868