Ticket #8043 (inprogress)
WorkspaceList property
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Backlog |
Component: | Framework | Keywords: | CORE |
Cc: | Blocked By: | ||
Blocking: | #8079 | Tester: |
Description (last modified by Owen Arnold) (diff)
A few algorithms that have been implemented lately (or are due to be implemented) such as Mean, and StitchMany #8042, have/will require a single property to accept a sequence of Workspaces.
At present, the only way that this can be done is to have a string list property from which the names/keys are used to map to real workspaces in the ADS. Proper checking of the workspace types then needs to be applied. For example, you may wish to validate that the workspaces are of the same type, or are the same shape.
The proposal of this ticket is to implement a WorkspaceList property onto which a new set of WorkspaceList validators can be applied.
Change History
comment:2 Changed 7 years ago by Owen Arnold
Comment by Russell Taylor on the work being planned here:
I think this sounds good, so long as it still does (or can) take in comma-separated string (there may be no alternative – I haven’t thought about it). Without that it would be more that tricky to employ it in existing algorithms. It should also be able to ‘hold’ the existing workspace validators. But I expect you’ve already thought of these things… Russell
comment:3 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #8043. New WorkspaceListProperty type.
Basic type template and tests only at this stage.
Changeset: 00dea52aa51e393c2ebb1e306c5d41a6ddb2831a
comment:4 Changed 7 years ago by Owen Arnold
refs #8043. Sticking point!
Changeset: e9d6ecabaf7aa17471dad4cc9d4ee94079c8d1e8
comment:5 Changed 7 years ago by Owen Arnold
refs #8043. TDD to extend and check functionality.
Specifically worked to ensure that things would work correctly via the algorithm interface. Particularly important is to correctly process string lists of workspace names (and return them too).
Changeset: e47180ed4260d3f70d95685cda18896f8e7d1838
comment:6 Changed 7 years ago by Owen Arnold
refs #8043. Add support for validators.
Changeset: bcfda02119e5018225decafb02e56111e2073ab4
comment:7 Changed 7 years ago by Owen Arnold
refs #8043. More operators exposed.
More operators exposed and some other fixes. Change so that the optional rules are stricter, especially via construction. Add overload for assignment. Add clone override and test.
Changeset: 977d72b0d98a7a652c5188e3c0d61a2d261e03b7
comment:8 Changed 7 years ago by Owen Arnold
- Keywords CORE added
These changes affect some core functionality in Kernel, so I've marked this ticket correspondingly.
comment:10 Changed 7 years ago by Peter Peterson
- Milestone changed from Backlog to Release 3.0
Should have moved things from backlog into the release before working on it.
comment:11 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.0 to Backlog
Moved out to backlog as not enough time in R3.0
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8888