Ticket #8045 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Move the cleaning of the data until the very end

Reported by: Jean Bilheux Owned by: Jean Bilheux
Priority: major Milestone: Release 3.0
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Keith Brown

Description


Attachments

remove_me.xml​ (2.1 KB) - added by Jean Bilheux 7 years ago.
Config file that can be used to test ticket

Change History

comment:1 Changed 7 years ago by Jean Bilheux

  • Status changed from new to inprogress
  • Owner set to Jean Bilheux

comment:2 Changed 7 years ago by JeanBilheux

Moved cleaning. Output seems to be much better. This refs #8045

Changeset: e6674c6c50f75c44358eafc4cd6f964643c5425b

comment:3 Changed 7 years ago by Jean Bilheux

Adding a switch to the geometry correction will also be part of this ticket.

comment:4 Changed 7 years ago by Jean Bilheux

to test this ticket:

  • start the RefLReduction GUI and notice the geometry correction flag
  • when the flag is off, using the same data and normalization file (with same peaks, background...) will give 1s as output
  • when the flag is on, using agin the same data and normalization file will not produced 1s, but data that are around 1.

the following config file can be used to run the test (see attach document)

Changed 7 years ago by Jean Bilheux

Config file that can be used to test ticket

comment:5 Changed 7 years ago by Jean Bilheux

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:7 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8045_moving_cleaning_function'

Full changeset: ​2876dd52268fcfc17bc40106e12f803ea4165567

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Reflectometry

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8890

Note: See TracTickets for help on using tickets.