InstrumentSelector generates bad signals when filtering by technique

[Samuel Jackson]

The instrument selector widget provides a signal called instrumentSelectionChanged() which is emitted every time the index of the combo box changes.

When filtering instruments by technique, the widget removes irrelevant instruments from the list using removeItem() (see line 210 in the cpp file). This causes the instrumentSelectionChanged() signal to be emitted every time an instrument is removed. This can cause issues with slow code listening to this event (such as loading an IDF file).

A better approach would probably be to block signals from being emitted while filtering the instruments and to check if there are any other places in the widget that could be emitting signals that shouldn't be listened too.

[Nick Draper]

Bulk move to assigned at the introduction of the triage step

[Federico Montesino Pouzols]

Address complaint from cppcheck, prefer prefix--, re #8051

Changeset: bbecdb2cfb934335d0d154547808870320312540

[Stuart Campbell]

This ticket has been transferred to github issue ​8896