Ticket #8060 (closed: fixed)
Create a Muller Ansatz cross section model
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6689 | Tester: | Michael Reuter |
Description
It is much simple than lookup model and good exercise before doing the lookup one.
Change History
comment:2 Changed 7 years ago by Alex Buts
- Status changed from new to inprogress
refs #8060 Created Muller Ansatz template
with contents equal to Strontium122
Changeset: 9d7ef2c330a22bd50e8a4e60c01573b784f8df9f
comment:6 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.1 to Backlog
Moved to backlog at the end of Release 3.1
comment:7 Changed 7 years ago by Alex Buts
refs #8060 Created Muller Ansatz template
with contents equal to Strontium122
Changeset: 5ab90a88d384b28b3fbb812765596dfbfb599709
comment:8 Changed 7 years ago by Alex Buts
refs #8060 should have Ansatz function defined.
Changeset: 004e1194fdfdc107ea563e7968dfd1781525813d
comment:9 Changed 7 years ago by Alex Buts
refs #8060 intermediate checkout
Ansatz looks more or less reasobable but looking at proper identification for external references
Changeset: 8e9fed8d9716308368256a076bccfd3f67df3c35
comment:10 Changed 7 years ago by Alex Buts
refs #8060 All formally here
The question is how to test all this to be sure it is all right.
Changeset: c650e2abdcc01638878d9263e30b668db299aaaf
comment:11 Changed 7 years ago by Alex Buts
refs #8060 Attempt to fix Unix error
Changeset: 2aa9b9b99244b0dbc980b45c559eb76e3ee5b6eb
comment:12 Changed 7 years ago by Russell Taylor
GCC compiler warnings are highlighting an error at line 196 of MullerAnsatz.cpp where a variable is being redeclared: https://builds.sns.gov/job/ornl_clean_rhel6_develop/2916/warnings17Result/
comment:13 Changed 7 years ago by Alex Buts
refs #8060 Fixing unix warnings.
Changeset: b341dd22c56df210949627f0b0650ab815da1806
comment:14 Changed 7 years ago by Alex Buts
refs #8060 should fix bunch of CPP check warnings
Changeset: eb2a6009549ecd8ac346f793746fc0ceb3520dfb
comment:16 Changed 6 years ago by Alex Buts
refs #8060 Unit test for MullerAnsatz
Changeset: ffb389206560d8fd414ac462995788bffda5626a
comment:17 Changed 6 years ago by Alex Buts
refs #8060 Fixing duplicate test class name
Changeset: b398aedf95e63bfea19bf5b3af860c5a8ea89034
comment:18 Changed 6 years ago by Alex Buts
refs #8060 Temporary disabling test with reasonable resolution
something strange is happening on Unix
Changeset: 0600028f499b4211b94f4d433aa2cee9faba2807
comment:19 Changed 6 years ago by Alex Buts
refs #8060 disabling another resolution test
Changeset: ffb01cd43abf95e427349cd8654cef6fb817c8cb
comment:20 Changed 6 years ago by Alex Buts
refs #8060 Proper testing for arguments and parameters
+ made public all Ansatz functions
Changeset: d545a93d5dd021c13e43f974bafb2d12bee3f652
comment:21 Changed 6 years ago by Alex Buts
refs #8060 trying to identify where the difference from different OS
comes
Changeset: 27988679f4035ea32725fcdfef7625cccc150748
comment:22 Changed 6 years ago by Alex Buts
refs #8060 Typing error
Changeset: 7a2ba988c6b1104181cb0de26e39012fcaa22dc8
comment:23 Changed 6 years ago by Alex Buts
refs #8060 More debug information.
Changeset: 296cb616e69650b93cbcfbb8c24694004ba8999b
comment:24 Changed 6 years ago by Alex Buts
refs #8060 Typing error
Changeset: 9d0168d6a1da6b958c3c6debfa16763ba10c238b
comment:25 Changed 6 years ago by Alex Buts
refs #8060 Avoid reallocating magnetic form factors table.
Changeset: d873e6bf8a853fdf41b9024e295d5a76068b3c72
comment:26 Changed 6 years ago by Alex Buts
refs #8060 removing some debug information
Changeset: 4badce29e1a763f6a4ac6dec94fa1a04c5536b30
comment:27 Changed 6 years ago by Alex Buts
refs #8060 debug info to understand what is on on RHEL
Changeset: bb96a77431b72fd62b6a5e0d3cd06894a13f0ccf
comment:28 Changed 6 years ago by Alex Buts
refs #8060 Giving it default constructor
which should not be necessary but would satisfy Coverity and may be give the answer on what is going on.
Changeset: e3e92c11931e5ad9251a676ba992f53a1c6bc0df
comment:29 Changed 6 years ago by Alex Buts
refs #8060 Removing debug information.
Changeset: 79b377567afbcd496ce960a9cde798f30f065cba
comment:30 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
Here is MullerAnsatz model which works and looks similar to existing Cromium122 model and unit test for this model.
It seems works, but nobody knows if it correct until somebody tried to use it in real scientific project. It is preparation work for parametric fitting model, so I would suggest tester looking through the code and accepting it as it is if nothing really terrible was found by code review.
comment:31 Changed 6 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:32 Changed 6 years ago by Alex Buts
refs #8060 Modified wrong parameter name, spotted by tester.
Changeset: 3c2554d2d40bbdd71cd3d4599db659acf0fd8e22
comment:33 Changed 6 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8060_MullerAnsatz'
Full changeset: 9d761924d1b45586e7293ea1943f8683fb6c7357
comment:34 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8905
