Ticket #8061 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

Remove auto-det param in LET_Parameters.xml

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.0
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Rob Bewley have requested that this gets removed from LET_Parameters.xml before the next release

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to inprogress

remove det-pos-source for LET. re #8061

Changeset: a87c2f976d1cba4b9dfe174209407f7c584b753d

comment:2 Changed 7 years ago by Russell Taylor

The above change breaks the ISISDirectInelastic.LETReduction system test (the result no longer matches the reference).

comment:3 Changed 7 years ago by Anders Markvardsen

thanks for spotting this. Looked and I don't understand way this should changed the result since this systemtest explicitely appear to define a .dat file.... Will try to ask whoever wrote dgreduce tomorrow. However, if this is not early enough do not hesitate to revert

comment:4 Changed 7 years ago by Russell Taylor

I tried to remove the merge but there's a later merge (another ticket) that gives a merge conflict on the rebase. I'm not going to try and deal with that - we can live with it failing overnight.

comment:5 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to duplicate

This will be done as part of #8057.

Note I have removed the branch on github created for this ticket

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that I will handle this in #8057

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Direct Inelastic

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8906

Note: See TracTickets for help on using tickets.