Ticket #8065 (closed: fixed)
'Rename' option at end of live data run is losing the run number for the SNS listener
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | LiveData |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
I think it's specific to the SNS listener as it comes through OK from the test 'Fake' & 'File' Listeners.
It's just getting a run number of 0 every time, even though the correct run number can be seen in the run_number property during the run. This definitely used to work.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #8065. Make sure the run number gets set on the live workspace.
With the previous code, it was not being set unless the workspace started from the beginning of the run. Now it should always get set, certainly at the end of the run but usually before.
The same applies to the run start time.
Changeset: 12ee0b5b2205b54ada1f7ff28966e487d0498616
comment:3 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester (who needs to be at the SNS): Branch is feature/8065_run_number_in_sns_live_listener
Things should now be fixed so that the run number is always there by the end of the run at least, and so the rename option works. You can check that out, though sometimes the instruments can be doing very long runs (I tested by starting algorithms for both HYS & SEQ to improve my odds that one would end quickly).
The run number should usually be set right at the start. The exception is if you ask to start from "N minutes ago" - then it only gets in right at the end. I've added a log message (at notice level) when it's set, so look out for that. You can also check the run_number and run_start logs within the live workspace.
comment:4 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:5 Changed 7 years ago by Michael Reuter
OK. Things seem to be working with the run number. It looks like things are fine as long as the live data is started while a run is on-going. I've been looking for an opportunity to try when a run has not started, but no luck so far. I think this is fine otherwise, so I'm going to pass it.
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8065_run_number_in_sns_live_listener'
Full changeset: fda3ad17232d9250580fdc81ac97a7d9064d9cd0
The problem came in I think with the changes to enable reading from the start of the run. In that situation, the run number does come through. If you start from 'now', though, the relevant packets are ignored.