Ticket #8068 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct the number of options to FitMethod in CalculateTransmission

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: trivial Milestone: Release 3.0
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Currently there is 7 options, but it should be 3.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

Correct the FitMethod option for CalculateTransmission

re #8068

Changeset: e5e2ebb8c324d0133f95c939f993bb28036e99c9

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

If you really think it is necessary to test (after code review), I can provide you a step by step on how to test it. But, I strongly believe it is not necessary.

comment:3 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:4 Changed 7 years ago by Russell Taylor

I guess this is an example of where it's better to use push_back to avoid having to remember to edit 2 places. Obviously, filling a vector this size will appear instant either way. (I realise I wrote this code in the first place. Hopefully I'm wiser 4 years on.)

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8068_calculate_transmission_option'

Full changeset: ​316971d9f4643c030bbaeceeff897dddde864341

comment:6 Changed 7 years ago by Gesner Passos

BTW, the 'error' was introduced by me a mounth ago when I added the polynomial fit.

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to SANS

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8913

Note: See TracTickets for help on using tickets.