Ticket #8072 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] Tidy Apply Corrections

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Peter Parker

Description

The apply corrections interface could use tidying up. For one thing, the user has to ensure that the corrections file is in a certain directory and follows a naming scheme. The container input is also optional under some circumstances.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Cc spencer.howells@… added

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8072 Tidying ApplyCorr and adding option for corrections file.

Changeset: 697b5b121ab3c7e791126f811b9355dc6dd7e1e9

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8072 Missed file extensions on file browser.

Changeset: 05b1ded768e994435e6b8c1af12ccd25c11d6d38

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8072 Reset default opening tab.

Changeset: fb40c4c723a5fe4fc44a406a5ba20ba2c5653793

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8072 Change scale label to be more specific.

Changeset: 08ba9e14c43e23d723b44d51e287749e31094e76

comment:6 Changed 7 years ago by Samuel Jackson

Refs #8072 Change extension on geometry change.

Also made scaling more clearly apply to can file only.

Changeset: 50938e65627159c9010f85247d8f3197b9dce863

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

I've made a few (mostly cosmetic) changes to the Apply Corrections tab in the IDA interface. You'll need to test that the interface still works as it did before. The old instructions on how to run apply corrections are still applicable for the most part and can be found here http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_Apply_Corrections

The only additional parameter is that the user can now directly input the corrections file rather than having it hard coded in a python script. You can use the attached files to run with corrections rather than having to run calculate corrections first.

Finally you should only be able to run Apply Corrections if you've either supplied a container or a corrections file (or both). If none are supplied you should be informed with an error message.

comment:8 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.0

comment:9 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:10 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8072_tidy_apply_corr'

Full changeset: ​0ee168695c73acfcffadfb548f4318a6c02e72cb

comment:11 Changed 7 years ago by Peter Parker

Looks good to me. Code changes make sense and the interface looks and acts as I would expect. The requirement of having at least one (or both) of the container/correction files specified is enforced correctly.

I was actually able to make the ApplyCorr routine fall over, but that was probably only because I made my own corrections file using the CalcCorr tab and I really don't know what I'm doing with that... In any event, nothing to do with these cosmetic changes.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8917

Note: See TracTickets for help on using tickets.