Ticket #8076 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

DGSReduction won't run MARI

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

When running DGSReduction on MARI data, DgsDiagnose fails handling the diag_spectra instrument parameter. It looks like MARI, LET and MERLIN parameter files were changed to have a "None" value for the parameter instead of it not being present. Since the parameter is not empty, but doesn't contain detector indicies, the tokenizer fails. This new case should be handled gracefully.

Attachments

MARI_test.py​ (787 bytes) - added by Michael Reuter 7 years ago.
MARI test script

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #8076. Handling None value for diag_spectra parameter.

Changeset: 5cd38169582d9cc4cc4c4f1bb62024df480890c9

Changed 7 years ago by Michael Reuter

MARI test script

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: Run the attached script before applying the fix to see that it fails. Then apply the fix and run the script again. It should run to completion.

comment:4 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:5 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8076_dgsdiagnose_diagspectra_handling'

Full changeset: ​3d620e95b80efc8038116da45b198fad620a7a29

comment:6 Changed 7 years ago by Alex Buts

clear problem with clear solution

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8921

Note: See TracTickets for help on using tickets.