Ticket #8097 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Cannot fix patch version number in build process

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

The patch version number used to be fixed by uncommenting the last line in Code/Mantid/Build/CMake/VersionNumber.cmake

Doing this now has no affect on the version number of the package generated.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Fix version number generation when we want to set the patch number

Refs #8097

Changeset: 2ffa6728098a00aa9cbbfb2942300c505608ef29

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Owner set to Martyn Gigg
  • Resolution set to fixed

Branch: bugfix/8097_fix_patch_number

Tester: Make sure the ENABLE_CPACK=ON cmake option is specified and then run cmake. It should by default generate a package with a datetime stamp as the patch number. Now open the Code/Mantid/Build/CMake/VersionNumber.cmake file and uncomment the last line and rerun cmake. It should now generate a version with the patch number fixed at that specified. BE SURE NOT TO COMMIT THE CHANGE AND REVERT IT AFTER TESTING

After each step above check that the Code/Mantid/Framework/Kernel/src/MantidVersion.cpp file has been generated with the correct information.

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8097_fix_patch_number'

Full changeset: d427920d2350422ee3da5d1e90dfa6c93ca2200b

comment:5 Changed 7 years ago by Peter Peterson

I tested this on RHEL6 by creating both "nightly" and "stable" versioned packages.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8942

Note: See TracTickets for help on using tickets.