Ticket #8107 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove the specific listeners from the list of instruments in the StartLiveData dialog.

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.0
Component: Framework Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

They are there for testing, but should not be visible in the released version. It seems like a suitable way to do this is to exclude them from release builds (i.e. check whether NDEBUG is defined). Either that, or they should be excluded from the combo-box in the algorithm dialog.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #8107. Only add listeners by name in debug builds.

Now that live data is becoming more mature & prominent, we should tidy up the interface by removing the specific listener names from the list of instruments that the user sees . They were just there for development/testing purposes, and as such I'm leaving them in for debug builds.

Changeset: f9c512caa13521e9e17bbcf5e234fca5e2aab064

comment:2 Changed 7 years ago by Russell Taylor

Re #8107. Fix unit tests in release mode.

Now that StartLiveData will only accept an instrument, not a listener name, add fake instruments for testing purposes.

Changeset: bc72701c38c1d53899bca96d33d974ab3732dddc

comment:3 Changed 7 years ago by Russell Taylor

Re #8107. Expose updateFacilities to python.

Also modify setFacility - why was it pointing to setString???

Changeset: 1232c78c4f2d6a05155f6dfbc8084a3bae50273c

comment:4 Changed 7 years ago by Russell Taylor

Re #8107. Fix python live data test.

Changeset: 0c68aad1e851dfb2094791fcfe77eb8b90ee059c

comment:5 Changed 7 years ago by Russell Taylor

Re #8107. We don't use auto_ptr.

In fact, there's no need for a heap allocation at all.

Changeset: ec1f504dcfd727ae927c07ee4ccd0835f82d22c3

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/8107_hide_listeners_in_startlivedata

In MantidPlot, look at Load -> Live Data. With a debug build, you should see entries in the Instrument combobox for FakeEventDataListener, FileEventDataListener, ISISHistoDataListener and SNSLiveEventDataListener (no matter what facility you have set). In a release build (such as a package from the jenkins builds), these entries will be missing and you will only see instrument names.

The reason they remain in debug builds is so that developers can still perform testing using them.

comment:7 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:8 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8107_hide_listeners_in_startlivedata'

Full changeset: c55108ba94a227e4afd52924f1a449224ebcd546

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8952

Note: See TracTickets for help on using tickets.