Ticket #8122 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Commit merged to systemtests/master that shouldn't have been

Reported by: Martyn Gigg Owned by: Samuel Jackson
Priority: blocker Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The system tests are currently broken on master on Windows. After some digging I discovered that this commit https://github.com/mantidproject/systemtests/commit/1c57c2b33fc6be17f567f09121219356a29f55bb relating to #7976 was merged on Friday. The merge of that commit also seems to have merged in https://github.com/mantidproject/systemtests/commit/06094c90762a84248e94af2e025ea04196168a13 to master. This commit was not supposed to have been merged yet as the ticket is not finished.

My suspicion is that the branch feature/7976_replace_flatabs_with_python was started based off feature/5421_IDA_bayes_interface rather than master.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

We need to undo the changes on master by doing

git new -p bugfix 8122 undo_accidental_merge
git revert 06094c90762a84248e94af2e025ea04196168a13
git publish
git checkbuild

After you have done this you'll need to do

git checkout feature/5421_IDA_bayes_interface
git checkbuild

to get the changes back on develop.

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8122_broken_systests_on_master'

Full changeset: 2774cf030f76a79ddf3f2071d3f70d8469640411

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8967

Note: See TracTickets for help on using tickets.