Ticket #8135 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add debug build of pyzmq to Windows third party repo

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: major Milestone: Release 3.1
Component: Python Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

The build of zmq added in #8006 cannot be imported into a debug build of MantidPlot. This means that the IPython interpreter will not work. The error is: 

ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
Are you trying to `import zmq` from the pyzmq source dir?
  at line 1 in 'New script'
  caused by line 44 in 'c:\GitHub\mantid\build\bin\Debug\lib\site-packages\zmq\__init__.py'

Try and get a debug build of this working.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Owner set to Martyn Gigg

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress
  • Keywords Maintenance added
  • Component changed from Framework to Python API
  • Milestone changed from Backlog to Release 3.1

comment:3 Changed 7 years ago by Martyn Gigg

Move references about python bundling to BundlePython.cmake file

Basically a tidyup to get all of the information in one place. Refs #8135

Changeset: 5f766cca96e57ea9ec6587329d0f6bc9134af38a

comment:4 Changed 7 years ago by Martyn Gigg

Use a script to setup the dev-build python bundle.

This simplifies the cmake code and makes it clearer what is happening when the bundling process occurs for a development build. Refs #8135

Changeset: 2713258f23da4017cb579bd1c3f63f49bef9892a

comment:5 Changed 7 years ago by Martyn Gigg

Fix a error in packaging up python dll.

Refs #8135

Changeset: 3a93f82ea15047fe11437ea6069d1ef3c5c2f9b0

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Some of the changes required to get this working were done under #8440.

Branch: feature/8135_pyzmq_win_debug

Tester: This needs to be tested on Windows with a debug build. There are a couple of preparation steps required first, before doing the build.

  1. Update third party using fetch_Third_Party.bat
  2. Open the bin\Debug\Lib\site-packages\zmq directory & delete libzmq.pyd.

Now merge the code and build MantidPlot. When built, start the program & try to open an IPython terminal. It should open cleanly without an error messages in the results log. Have a cursory play to check that it seems to function correctly.

Last edited 7 years ago by Martyn Gigg (previous) (diff)

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 7 years ago by Nick Draper

tested with some basic python loops and printing

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8135_pyzmq_win_debug'

Full changeset: ​0e26e90a0add86d8b899c591e6a820da7006328f

comment:10 Changed 7 years ago by Martyn Gigg

Move references about python bundling to BundlePython.cmake file

Basically a tidyup to get all of the information in one place. Refs #8135

Changeset: a5b3bf447667af92e23d7996728de7bab7b74249

comment:11 Changed 7 years ago by Martyn Gigg

Use a script to setup the dev-build python bundle.

This simplifies the cmake code and makes it clearer what is happening when the bundling process occurs for a development build. Refs #8135

Changeset: 3904c97fe69f37a4360556c3d46218cd66075f72

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8980

Note: See TracTickets for help on using tickets.