Ticket #8137 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Skip tests using expat parser

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By: #8124
Blocking: Tester: Nick Draper

Description

Tests used as part of #8124 do not work on windows in debug mode. This is because config.py uses the expat parser via the XMLElement module, which is not built in debug mode on windows.

The solution at the moment is to skip the tests on this platform. The Config class is not hooked up to anything get, but this presents some options moving forward.

1) Build the expat module in debug on windows and add it to our repositories

2) Disable the Reflectometry GUI for anything other than the Release builds. As this is what the Config class is intended for.

3) Abandon the xml aspects of this class and have it read a plain text file as key, value pairs.

Nevertheless, the current tests well need to be skipped over for the timebeing.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8137. Skip tests if module import impossible.

Changeset: d82a5435738862df30bc777c62b8f18c019bfb8b

comment:2 Changed 7 years ago by Owen Arnold

refs #8137. No skipif decorator in python 2.6

Changeset: 95fb295356387d18eaab09d2f9c6479fff596d6f

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tests should run in Debug mode on windows. I've just kicked off these builds on the build server (broken GMT AM 16th Oct 2013), so these should all pass now. Please check that these tests still run on other platforms. You can do this using:

ctest -R ConfigTest -V

9 tests should run.

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:5 Changed 7 years ago by Nick Draper

Debug: 0 tests

Release: 9 tests

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8137_fix_tests'

Full changeset: ​4d23b1063db84fcd755da038c4b52b244cd24543

comment:7 Changed 7 years ago by Owen Arnold

refs #8137. Skip tests if module import impossible.

Changeset: fb2f8b4511389496b5eb4cd04fc13d282a6c5fbb

comment:8 Changed 7 years ago by Owen Arnold

refs #8137. No skipif decorator in python 2.6

Changeset: 5bb3ecf851c77a48c5921313d8242b3bc1cef082

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8982

Note: See TracTickets for help on using tickets.