Ticket #8149 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Constrain inputs for Stitch1D

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

This is an issue that has been picked up at the PSI. Stitch1D fails internally upon Integrate if you do not first convert the input workspaces to histogram workspaces.

I could apply these conversions internally, but i think it's better to just constrain the inputs, because I don't want to create and manage temporary histogrammed workspaces within the algorithm.

This must be fixed for the next release.

Attachments

q366.nxs (87.2 KB) - added by Owen Arnold 7 years ago.
q367.nxs (87.0 KB) - added by Owen Arnold 7 years ago.
amostitch.gif (11.7 KB) - added by Owen Arnold 7 years ago.
Screen Shot 2013-10-17 at 13.40.57.png (31.9 KB) - added by Owen Arnold 7 years ago.

Change History

Changed 7 years ago by Owen Arnold

Changed 7 years ago by Owen Arnold

Changed 7 years ago by Owen Arnold

comment:1 Changed 7 years ago by Owen Arnold

Tester: Running stitch1d with the arguments (see attached image) causes a failure:

Stitch1D-[Notice] Stitch1D started
Rebin-[Notice] Rebin started (child)
Rebin-[Notice] Rebin successful, Duration 0.01 seconds
Rebin-[Notice] Rebin started (child)
Rebin-[Notice] Rebin successful, Duration 0.01 seconds
Stitch1D-[Error] Error in execution of algorithm Stitch1D:
Stitch1D-[Error] Invalid value for property InputWorkspace
(MatrixWorkspace) "lhs_rebinned": The workspace must contain histogram data
at line 68 in
'/home/scratch/mantdiwork/mantid/Code/Mantid/Framework/PythonInterface/plugins/algorithms/Stitch1D.py'

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8149. Constrain input workspace types.

Constrain the input workspace types and introduce tests for this behaviour. Also add behaviour to documentation.

Changeset: 4a6dd4e3687c182389aefaac8a2a0b658879839e

comment:3 Changed 7 years ago by Owen Arnold

Tester: Now that the fix has been applied. Try it again and the algorithms should not continue processing until you apply ConvertToHistogram to both of the inputs. When you do, you should get a plot like the attached.

Changed 7 years ago by Owen Arnold

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8149_fix_stitch_defect'

Full changeset: 417b25a7ba060aa59fb54c770f7f283c55e5a4b0

comment:7 Changed 7 years ago by Gesner Passos

It now enforces histogram data correctly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8994

Note: See TracTickets for help on using tickets.