Ticket #8152 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[ICAT] Improve datetime result

Reported by: Jay Rainey Owned by: Jay Rainey
Priority: major Milestone: Release 3.1
Component: Framework Keywords: ICAT,ICAT4,maintenance
Cc: Blocked By:
Blocking: #8244 Tester: Gesner Passos

Description

Currently, the getTimevalue method in CatalogSearchParam.cpp does not return the correct day (it's off by one), but has been temporarily fixed in #6457.

The method needs to be corrected, ideally making use of the DateAndTime class to simplify the complexity of it.

Change History

comment:1 Changed 7 years ago by Jay Rainey

  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Jay Rainey

  • Summary changed from Improve ICAT datetime result to [ICAT] Improve datetime result

comment:3 Changed 7 years ago by Jay Rainey

  • Status changed from new to inprogress

Merge branch 'feature/8152_icat_datetime_improvement' into develop. Refs #8152

Conflicts:

Code/Mantid/Framework/ICat/inc/MantidICat/CatalogSearchParam.h Code/Mantid/Framework/ICat/src/CatalogSearchParam.cpp

Changeset: 664cad8d921d3b86e630798ac9997c7024cd9e25

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

I made changes to this ticket, and published them to a branch with a different ticket name (#8153). I have fixed this, and you can find my changes on ​github.

To test

  1. Open Mantid and enable debugging in the console log.
  2. Select a start and end date (I am aware of the ​issues with the calendar picker) and perform a search.
  3. Note the start and end date in the search query. They must have the correct day, and the start and end times should be: 
start time -> 00:00:00
end time   -> 23:59:59

As I have re-factored a method that made use of in the catalog search algorithm a code review would be appreciated.

comment:5 Changed 7 years ago by Jay Rainey

Removed unused boost header file. Refs #8152.

Changeset: 874027b24e09700965bcf5d5d9828cc40421bdda

comment:6 Changed 7 years ago by Jay Rainey

  • Blocking 8244 added

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:8 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8152_icat_datetime_improvement'

Full changeset: ​fcd315af1521be8ff6059d1efe65f7311e39e79a

comment:9 Changed 7 years ago by Gesner Passos

Working as expected, besides, the new code is much easier to follow than the previous one.

comment:10 Changed 7 years ago by Jay Rainey

Merge branch 'feature/8152_icat_datetime_improvement' into develop. Refs #8152

Conflicts:

Code/Mantid/Framework/ICat/inc/MantidICat/CatalogSearchParam.h Code/Mantid/Framework/ICat/src/CatalogSearchParam.cpp

Changeset: 664cad8d921d3b86e630798ac9997c7024cd9e25

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8997

Note: See TracTickets for help on using tickets.