Ticket #8156 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SANS error processing -add data

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: blocker Milestone: Release 3.0
Component: SANS Keywords:
Cc: richard.heenan@… Blocked By:
Blocking: Tester: Nick Draper

Description

The ticket #8052 introduced a problem, that makes the reduction fail to processed files.

from mantid.simpleapi import *
from mantid import config
import ISISCommandInterface as ici
ici.LOQ()
ici.Detector("main-detector-bank")
ici.Set1D()
ici.MaskFile('MASK.094AA') 
ici.AssignSample('LOQ80047-add.nxs')

Reproduces the problem.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8156: Does not try to find file path twice

The _data_file is already a full_path in this stage. It is useless, and, as showed, error_prone to try to do it.

Changeset: 96e7c531ec60f0404c47416ffc627dd521a636e1

comment:2 Changed 7 years ago by Gesner Passos

re #8156 correct getFilePathFromWorkspace

It could be different, but it is necessary to wait to fix #8158.

Changeset: 58d2d2d6c0655fed08c67d314c4123fdceab81f7

comment:3 Changed 7 years ago by Gesner Passos

re #8156: getFilePathFromWorkspace test coverage

Changeset: 7baa33a42b60ed46af6816fbb646509dedc74bd5

comment:4 Changed 7 years ago by Gesner Passos

LOQSANSUtilityTest: make path system independent

Windows uses backslashs for path, change it to forward slashes before comparing paths.

re #8156

Changeset: 863cf45ba119de0a63b37eec1d81f54e83779006

comment:5 Changed 7 years ago by Gesner Passos

LOQSANSUtility: correct problem with MAC OS

I do not quite know why, but Mac is reporting that the file was saved as -ADD. So, it checks to change that, because, it does allow to load the file with that name as well.

re #8156

Changeset: 8c4612b73ffc00c804fc4cab9549330ca3519120

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

The file where the problem was first viewed is inside ndxloq/user/processed.

Tester:

Run the script again and check that it is now correct. Besides, a branch with the same name (bugfix/8156_assign_processed_data) was created for systemtests to ensure that this problem does not repeat. Rembembe to update both mantid and systemtests.

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 7 years ago by Nick Draper

Tested using script above

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8156_assign_processed_data'

Full changeset: ad730313c269bcc3d07b533e19977b92b212e379

comment:10 Changed 7 years ago by Nick Draper

Merge remote-tracking branch 'origin/bugfix/8156_assign_processed_data'

Full changeset: 9998ec841e4a4329ce1a0dd70e6317bec797f1df

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9001

Note: See TracTickets for help on using tickets.