Ticket #8159 (closed: fixed)
Load doesn't work for preNexus files
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8143 | Tester: | Peter Peterson |
Description
It chooses LoadEventPreNexus alright, but the error when it tries to run is:
Load started Property "EVENTFILENAME" is not set to a valid value: "No file specified.". Property "EVENTFILENAME" is not set to a valid value: "No file specified.". Error in execution of algorithm Load: Some invalid Properties found
It's losing the fact that the property is not called 'Filename' in this case.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #8159. Make sure the filename property's name is set correctly.
In the case of LoadEventPreNexus is is "EventFilename". It seems that for everything else is is "Filename" because the variable that holds this is empty by the time the algorithm comes to run (though the loader is selected correctly). I've factored out the method that sets the variable and called it again from within a method that exec() calls.
Changeset: b289687e0acc25bd096df0df1fa4f273deee1cdd
comment:3 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: The branch is bugfix/8159_fix_load_for_prenexus in both the mantid and systemtest repos
To test - try to use Load to load a prenexus (*_neutron_event.dat). It should now work. A file of this type was added to the systemtests repo so that the LoadLotsOfFiles test will attempt to use Load on it. Previously, there were none in that repo so Load was entirely untested for this type of file.
comment:4 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:5 Changed 7 years ago by Peter Peterson
- Status changed from verifying to closed
Merge remote branch 'origin/bugfix/8159_fix_load_for_prenexus'
Full changeset: b9c99c33781cf71bee2ee3b62169e079efb8fb2d
comment:6 Changed 7 years ago by Peter Peterson
Merge remote branch 'origin/bugfix/8159_fix_load_for_prenexus'
Full changeset: 262ba31bfb2d1862eef3e0a7e59e732c07e3d00e
Re #8159. Add CNCS prenexus file.
There are no prenexus files in this repo at the moment. Adding this will mean that the LoadLotsOfFiles test will pick it up - and will fail until I fix the issue in Mantid.
Changeset: b95f7b0233bdbea78cd51b7cfaf1d51c75b644b0