Ticket #8163 (closed: fixed)
Muon: run_number should appear as log value
| Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.1 |
| Component: | Muon | Keywords: | |
| Cc: | anders.markvardsen@… | Blocked By: | |
| Blocking: | #7367 | Tester: | Gesner Passos |
Description
Stephen Cottrell noted that in Muon Analysis results table run_number is added automatically, without user being aware of it prior to the table creation. This is not transparent.
Additionally, user is unable to create a table with run_number and fitting results only, because he should select at least one log value for interface to allow that.
Making it so that run_number appears as another log value in the upper table would solve all these difficulties.
Change History
comment:1 Changed 7 years ago by Arturs Bekasovs
- Status changed from new to inprogress
- Blocking 7367 removed
- Milestone changed from Backlog to Release 3.1
comment:2 Changed 7 years ago by Arturs Bekasovs
- Blocking 7367 added
(In #7367) Trac playing tricks again.
comment:4 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Add run_number to log list.
Don't add it automatically. Gets represented as double for now.
Changeset: fe4c01a91e9ca34a6b0d7a56d133ae8402c8228e
comment:5 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Using QVariant to store log values.
Changeset: 5483e0b920e9b75dbbff69ee2e0b6cee790c23f5
comment:6 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Better variable name.
Changeset: a2f4c84b2324b4c919d2b659ae395d56695f8cb9
comment:7 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Make string logs to be displayed as text.
This is done in general way, so if we'll need to add logs of various types it will be easy.
Changeset: ccee46d2f62eb188e93dfee114ccc5b74f14f3a6
comment:8 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Select Run Number log value by default.
Changeset: 920bc91357a5fe70c513965a06d0d5fa0ed38a55
comment:9 Changed 7 years ago by Arturs Bekasovs
Refs #8163. Remember if user has de-selected the log value.
Plus solved another problem with remembered states not being cleared before saving new ones. It caused check-box which was once checked by user to be re-checked every time results tab is opened.
Changeset: 222b579b56548357ee20393930964500f25867b7
comment:10 Changed 7 years ago by Arturs Bekasovs
Tester:
In MuonAnalysis, please check that Run Number is being added to a list of Log Values on the Results Table tab.
When you open the Result Table tab, Run Number log value should be chosen by default. However, when you deselect it, make sure your choice is remembered, i.e. when you go to the tab next time it should not be re-selected.
It should behave in the same way as all the other Log Values, i.e. you should be able to select/deselect it and thus resulting table should contain/not-contain Run Number column. Make sure Run Number column has type type "Text" and plot designation "Label" - it corresponds to how it was represented previously.
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:13 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8163_muon_runnumber_as_log'
Full changeset: 39093ecb494dbc525d6c94764383517f5ee4be9f
comment:14 Changed 7 years ago by Gesner Passos
Now you have the option to de/select run number and all the other options, as described in this ticket.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9008
(In #7367) The file is loaded correctly if facility is set to SmuS.
Warning message when opening the interface should be removed though.
The problem with a given file is that it doesn't have any log files in it, which means we couldn't get our results table. This should be solved in #8163, as then we will at least have run_number to plot against.