Ticket #8168 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add MaskBinTable to AlignAndFocusPowder

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

In order to make life easier for the SNAP users, add a MaskBinsTable to AlignAndFocusPowder so they can just use it.

Attachments

diff.jpg​ (139.0 KB) - added by Vickie Lynch 7 years ago.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8168. Added optional MaskBinsTable to the mix.

Changeset: c8024db9f92c5cd337fc1a0f77e20038cbeb0d0a

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Tester set to Wenduo Zhou

This is on ​feature/8168_maskbintable.

To test: Make sure that it runs with and without specifying a MaskBinTable. While the target of the change is SNAP, it should work with any instrument.

comment:3 Changed 7 years ago by Wenduo Zhou

Modified API for slow down issue. Refs #8169.

Changeset: 6d88d359bc7463b5fd939a163ec57c16f4630c40

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

This looks like it should be in the release

comment:5 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester changed from Wenduo Zhou to Vickie Lynch

Changed 7 years ago by Vickie Lynch

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

There is a slight shift of the peaks in attached file, but I do not think it is because of this ticket so I am passing. 

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################
Load(Filename=r'/home/vel/workspace/PG3_4832_event.nxs',OutputWorkspace='PG3_4832_event')
AlignAndFocusPowder(InputWorkspace='PG3_4832_event',OutputWorkspace='old',CalFileName=r'/home/vel/workspace/PG3_calibrate_d4832_2012_05_03.cal',Params='0.5,-0.0004,2.5')
ExtractMaskToTable(InputWorkspace='old',OutputWorkspace='mask_table',Xmin='0',Xmax='1.0000000000000001e+300')
AlignAndFocusPowder(InputWorkspace='PG3_4832_event',OutputWorkspace='new',GroupingWorkspace='PG3_group',OffsetsWorkspace='PG3_offsets',MaskBinTable='mask_table',Params='0.5,-0.0004,2.5')
Minus(LHSWorkspace='old',RHSWorkspace='new',OutputWorkspace='diff')

comment:7 Changed 7 years ago by Vickie Lynch

Merge remote branch 'origin/feature/8168_maskbintable'

Full changeset: ​e39a2f719fedc1abbf19dd1d4e9624046d7d181a

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9013

Note: See TracTickets for help on using tickets.