Python Runner falls over with a path name with an apostrophe

[Samuel Jackson]

A user was reporting the following error when trying to run the ConvertToEnergy interface and selecting the OSIRIS instrument.

"Welcome to Mantid - Manipulation and Analysis Toolkit for Instrument Data
ParaView is not available
File "<Interface>", line 1
    import sys; sys.stdout = open('C:/Users/AlexO'M/AppData/Local/Temp/qt_temp.gq3868', 'w')
                                                
SyntaxError: invalid syntax"

It appears that the issue is caused by the fact that the user has an apostrophe in his home folder name. This caused the python runner to fall over because the string was not properly escaped.

[Samuel Jackson]

Refs #8170 Escape quotes around path name for temp file

Changeset: 07f69d7888a20cb4e29d55b416e2f6c606268c2c

[Samuel Jackson]

I checked that this change fixed the issue in Windows 8 (the OS the user was using) with the same folder name as reported by the user. I investigated the possibility of the user having a double quote in their path name but it appears to be a reserved character:

​http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#file_and_directory_names

To Tester

I would suggest that to verify this you either rename your home folder to include an apostrophe or create a new user account, run a previous version Mantid and confirm you can reproduce the error. Then check the bugfix works.

[Roman Tolchenov]

Tested by setting environment variable TMP to a path containing a single quote. A build before the fix fails and the one with the fix works.

It is possible for TMP to contain a double quote and it will break any interface. Opened ticket #8242 to have a thought about it.

[Roman Tolchenov]

Merge remote-tracking branch 'origin/bugfix/8170_python_runner_bug'

Full changeset: ​7582d89d9499c7bca7d7159f56cee315da27a237

[Stuart Campbell]

This ticket has been transferred to github issue ​9015