Ticket #8176 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Indirect] Add Indirect Transmission algorithm

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Karl Palmen

Description

Ticket request from Spencer. Add a new python algorithm called indirect Transmission to Mantid. Note that this is a different algorithm from the indirect transmission routine in IndirectEnergyConversion.

Attachments

IndirectTransmission.py​ (4.5 KB) - added by Samuel Jackson 7 years ago.
Script to be added

Change History

Changed 7 years ago by Samuel Jackson

Script to be added

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8176 Add system test skeleton code for new algorithm.

Changeset: e3dc020411bd801b014f6900b1e02ce51dd97cbf

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8176 Write system test for IndirectTransmission

Changeset: 504464da84c94dedda083c715923d907a87e26d7

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8176 Add algorithm to Mantid.

Changeset: 8452054c83cd5f485495b2c2fec8d921621ecd67

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8176 Fixed algorithm output

Changeset: 417300b1910483fe6aa5f3d73c0c92697d6515ae

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8176 Change algorithm parameter names to remove space.

Changeset: 1515194640727007e6725e4a6bb6b4033f6629c7

comment:6 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:7 Changed 7 years ago by Samuel Jackson

Refs #8176 Tidy output to table.

Changeset: 298fb787e562c518dca5438e1f51617d0677fdf9

comment:8 Changed 7 years ago by Samuel Jackson

Refs #8176 Fix outputting to log.

Changeset: 490bb22cfda2ce55873aa1f10169d5c854d6fd83

comment:9 Changed 7 years ago by Martyn Gigg

The system tests are currently broken on develop.

The reason is that the new Python algorithm IndirectTransmission has the import of IndirectCommon in the wrong place. It needs to be moved from line 12 to be the first line inside the PyExec method.

This unfortunately necessary to workaround a current bug with import modules that are loading the simpleapi while it is still being built.

comment:10 Changed 7 years ago by Samuel Jackson

Refs #8176 Fix for broken system tests

Changeset: b5fe6c0571244f27c6fff8d9fc5f224ab6ebb775

comment:11 Changed 7 years ago by Samuel Jackson

Refs #8176 Swapped wavelength to have its own row.

Changeset: 73b82b91f73bdb696f9e8280167b80a25f0d2439

comment:12 Changed 7 years ago by Samuel Jackson

Refs #8176 Updated reference result.

Changeset: 3d8f92717962f1edd44b7e7aab6e69c686760b27

comment:13 Changed 7 years ago by Samuel Jackson

Refs #8176 Update reference result for IndirectTransmission

Changeset: d58175bebefec1c931c86e680c9d74a4db7b0269

comment:14 Changed 7 years ago by Samuel Jackson

Refs #8176 Updated column type.

Changeset: e55c9c38ece6671b7c45be5b168fc467874c9a40

comment:15 Changed 7 years ago by Samuel Jackson

Refs #8176 Give algorithm a proper output workspace property.

Changeset: a5e472c0dd364bad46cfbc6beb982ce0ad32747a

comment:16 Changed 7 years ago by Samuel Jackson

Refs #8176 Update system test.

Changeset: 298ce6ee059eabcfd03064e7d51c0ffea8baa640

comment:17 Changed 7 years ago by Samuel Jackson

To Tester

You can test the algorithm using the following example script: 

instrument = "IRIS"
analyser = "graphite"
reflection = "002"

#using water
formula = "H2-O"
density = 0.1
thickness = 0.1

IndirectTransmission(Instrument=instrument, Analyser=analyser, Reflection=reflection,ChemicalFormula=formula, NumberDensity=density, Thickness=thickness,OutputWorkspace='IRIS_graphite_002_Transmission')

Check that it works and the system tests are passing. Do a code review. This ticket needs merging in the system tests as well.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:18 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:20 Changed 7 years ago by Karl Palmen

Test script works and produces a table workspace that seems to have sensible results in it.

comment:21 Changed 7 years ago by Karl Palmen

System test looks OK and is assumed to work, because 2 weeks have passed since ticket was set to fixed/verify.

comment:22 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8176_indirect_trans_alg'

Full changeset: ​a051d403d1fd2a96f33c518a9447e3f33b1546b2

comment:23 Changed 7 years ago by Karl Palmen

Merge remote-tracking branch 'origin/feature/8176_indirect_trans_alg'

Full changeset: ​a223174c2a73191a3ef10b63b80219d9136883c4

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9021

Note: See TracTickets for help on using tickets.