Ticket #8178 (closed: worksforme)

Opened 7 years ago

Last modified 5 years ago

Passing a bad Chemical Formula to SetSampleMatrial causes Mantid to crash

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords: student
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Passing something that isn't a valid chemical formula causes Mantid to crash. For example entering "123" causes the crash. While it's unlikely a user would do this, it would be better to at least catch the error.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Owner changed from Samuel Jackson to Anyone

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:3 Changed 6 years ago by Nick Draper

  • Keywords student added

comment:4 Changed 6 years ago by Martyn Gigg

  • Milestone changed from Backlog to Release 3.3

comment:5 Changed 6 years ago by Dan Nixon

This seems to be fixed now.

Entering "123" in the ChemicalFormula field gives the following error in the results log: 

Error in execution of algorithm SetSampleMaterial:
Failed to find an atom with symbol=1 and a=0

comment:6 Changed 6 years ago by Dan Nixon

  • Owner changed from Anyone to Dan Nixon
  • Status changed from assigned to verify
  • Resolution set to worksforme

comment:7 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:8 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

It seems to have been fixed by other ticket. It still fails in 3.1.1, but works in 3.2

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9023

Note: See TracTickets for help on using tickets.