Ticket #818 (closed: wontfix)

Opened 11 years ago

Last modified 5 years ago

Clean up geometry Component inheritance tree

Reported by: Laurent Chapon Owned by:
Priority: major Milestone: Iteration 19
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

There are no reasons at all for some of the virtual member functions such as getPos getRot etc.......All of this should be in the base class.

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Status changed from new to closed
  • Resolution set to wontfix

Unfortunately these do need to be virtual in order to allow for moving parts in different workspaces.

GetPos makes a call to the parent. In the base instrument this can simple be the parent, but for a moved component this needs to be the parameterised parent.

We can and will however neaten some of this up, and we are planning on including caching of the final positions in order to speed up access.

comment:2 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1666

Note: See TracTickets for help on using tickets.