Ticket #8194 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add joined McStas loader

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: torben.nielsen@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Combine LoadMcStasEventNexus and LoadMcStasNexus into LoadMcStas

To be in sync with next McStas release and very recent improved changes to how new McStas will write Nexus files this ticket is set to critical and may not be closed before next week

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to inprogress

Added new mcstas loader. re #8194

Provided by Torben Nielsen. Here modified to adjust names of workspaces added to workspace group

Changeset: a7e738a58c02558ce586d3e8c1ea7928f67a1408

comment:2 Changed 7 years ago by Anders Markvardsen

Merge branch 'feature/8194_mcstas' into develop. re #8194

Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

It looks like LoadMaskingFile has been removed recently from development branch which appear to have caused this conflict

Changeset: 3a0c38a81804ec885517408e441e474f2a2632ee

comment:3 Changed 7 years ago by Anders Markvardsen

Added new mcstas loader. re #8194

Provided by Torben Nielsen. Here modified to adjust names of workspaces added to workspace group

Changeset: 0657446e00f19b40a4636ad2e2b91b17d92b45bb

comment:4 Changed 7 years ago by Anders Markvardsen

Merge branch 'origin/master' into feature/8194_mcstas. re #8194

Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt Code/Mantid/scripts/test/ConfigTest.py

Changeset: 95fa42c2f25b94cf14bce1ef38f0e2d25291503d

comment:5 Changed 7 years ago by Anders Markvardsen

Torben update to wiki. re #8194

Changeset: aedadef66be69fedd590058d471cb53bbe2510fb

comment:6 Changed 7 years ago by Anders Markvardsen

create workspace name from title rather than dataname. re #8194

Changeset: 060284d44dc1146b7802e770920dbc0d0eebefd1

comment:7 Changed 7 years ago by Anders Markvardsen

Remove old mcstas reader. re #8194

This reads some intermediate mcstas nexus format not part of a formal mcstas release

The new loadmcstas supports what will be the next official mcstas release

Changeset: 7b02c0d6c4d50e7c2ae22f68be668cc8f256f640

comment:8 Changed 7 years ago by Anders Markvardsen

Changed so will load relevant mcstas loader. re #8194

i.e. LoadMcStasNexus for old mcstas nexus and LoadMcStas for soon to be released mcstas version

Changeset: 2a97e761bcb8c89703420f248914d8986f865b34

comment:9 Changed 7 years ago by Anders Markvardsen

set loadmcstasnexus to return confidence zero. re #8194

Changeset: 961b03d04197e053bf4880ee4a288e70bc7bf197

comment:10 Changed 7 years ago by Anders Markvardsen

output names in group include group name also. re #8194

Changeset: d4263d9a2942ece62ec4c3f8a8926efbdc3ab478

comment:11 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test as a minimum do

  1. Load dataset mcstas_event_hist.h5 in AutoTestData

which should generate a GroupWorkspace containing 1 EventWorkspace and 4 Workspace2D

(Note there is a known side effect which is not related to code in LoadMcStas.cpp #8269)

comment:12 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:13 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8194_mcstas'

Full changeset: ​8f4a71ebfaff1448d0e5b7f9ffe656e84f769302

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9039

Note: See TracTickets for help on using tickets.