Ticket #8198 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Axes Dialog Box Ux improvements

Reported by: Gesner Passos Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Dan Nixon) (diff)

While testing #7865 I've come across some things I thing could be improved for the UX using the Axes Dialog Box.

What I report here you may reproduce using loading the file below and opening the ColorFillPlot on it.

http://trac.mantidproject.org/mantid/attachment/ticket/7865/19675_sans_2d.nxs

  • Tab (Scale), select Right, and you have a From (0) To (23.88359091237): we do not need this precision.
  • Tab (Scale), select Top, you can change any settings, but it will not show anything, because in the Tab(Axis) the show is not selected. Is Disabling invisible axis a good option?
  • Tab (Scale), select Left, select Show Axis Break, change Steps Before Break to 0.2, Apply, and the numbers disappear. If you want to go back to the Guess, you can not write Guess on Steps Before Break, you have to write 0 or go using the spinbox with a mouse.
  • Tab (Scale), Inverted option: it is not clear what it does (a tool tip is necessary). Besides, it seems to change only in logarithm mode and not in a pleasant way. If it is only for logarithm, disable it in linear mode.
  • Tab (Scale), select Right, change the Major Ticks, and apply for each step. It changes just for some steps. If it does not accept all values, a combo box could be considered here.
  • Why the option Canvas Frame (Tab General) is here and not in the Tab Layer of Plot Properties?

Change History

comment:1 Changed 7 years ago by Gesner Passos

Keith asked to add new requirement (#7865#comment40)

Define what Antialised was supposed to do. A ToolTip is worth to define its behavior.

comment:2 Changed 7 years ago by Keith Brown

Add new requirement:

Tab (Scale), Position and Width spinboxes shouldn't contain the units, rather a label should do it outside the box.

comment:3 Changed 7 years ago by Arturs Bekasovs

A slight problem from me as well:

To reproduce:

  1. Plot something.
  2. Double-click on any of the axis labels to open Plot Options.
  3. On the right, check Step radio-button and set a number which is tiny in comparison with axis max value.
  4. Click OK. The plot window and Mantid itself becomes quite unresponsive until you close the plot window.

It looks like the reason for it is the plot trying to render thousands of these axis labels, which can be very slow.

I think some kind of lower limit should be set for that field, in the same way as Major/Minor tick fields have upper limits, just to make sure that the resulting number of labels is not too big. Limit should obviously depend on the max value for the axis.

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:5 Changed 6 years ago by Keith Brown

It feels like this could do with a custom dialog ui file made, as it was a nightmare to work with in #7865

comment:6 Changed 6 years ago by Keith Brown

  • Owner changed from Keith Brown to Anyone

not going to get this done before i leave, leaving to anyone

comment:7 Changed 6 years ago by Dan Nixon

  • Owner changed from Anyone to Dan Nixon

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fix for scale issue mentioned in comment:3

Refs #8198

Changeset: bb489aaeeb2caab2dccf9d5bdc3cbe030b71ec88

comment:9 Changed 6 years ago by Dan Nixon

Added lower precision for values displayed for graphs

I added this into ApplicationWindow in the chance it is needed for this purpose elsewhere Refs #8198

Changeset: f2d8ebbf28f494f47a6871f618e58e0f7b116b22

comment:10 Changed 6 years ago by Dan Nixon

Allow typing Guess, guess and GUESS into axis break fields

Refs #8198

Changeset: 044ea1367c7655ec75801266354b3211b337ea99

comment:11 Changed 6 years ago by Dan Nixon

Diabled scale editing options for axis which are disabled

Refs #8198

Changeset: 853b7bc2e1fb2695799e687c0f00fad10df03a3c

comment:12 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:13 Changed 6 years ago by Dan Nixon

Fix build error caused by class variable

Refs #8198

Changeset: 8c3fdf613442bf634e3090df32f6199c80350aa2

comment:14 Changed 6 years ago by Dan Nixon

Graph::setScale has a lot of code commented out, including code which uses the inverted parameter, hence checking the Invert box has no effect.

comment:15 Changed 6 years ago by Dan Nixon

Major and minor tick options are the maximum you want to see on the graph, QwtScaleEngine decides how may ticks a graph should have.

I have changed the labels to reflect this, and will add tool tips for the input fields.

comment:16 Changed 6 years ago by Dan Nixon

Modified labels on axis tick settings

To better indicate what they actually do Refs #8198

Changeset: f28d09e6479df2f58f6f4c9c127084c34f875fae

comment:17 Changed 6 years ago by Dan Nixon

Moved Position and Width units to labels

As per comment:2 Refs #8198

Changeset: 5869408d4095f1420b67040b05f1d083c1d27918

comment:18 Changed 6 years ago by Dan Nixon

Temporary hide Invert checkbox since it does nothing

Refs #8198

Changeset: 0432fc929f0c15d28a471b72ea11460d6bdeec7f

comment:19 Changed 6 years ago by Dan Nixon

Added tooltip for anti-alias

Refs #8198

Changeset: 519e35827a7db1c74e1d593c1c70a37edfa29c05

comment:20 Changed 6 years ago by Dan Nixon

I'm not convinced the anti-aliasing really does much, it does request that QtiPlot performs it but the resulting plots are not noticeably different.

comment:21 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:22 Changed 6 years ago by Dan Nixon

Moved canvas frame to plot properties

Refs #8198

Changeset: fa00fb2ff396bfcb4e6c2a22b3c217f02c5db941

comment:23 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:24 Changed 6 years ago by Peter Parker

  • Milestone changed from Backlog to Release 3.3

comment:25 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:26 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Tested on win7. Double clicking on an axis crashes mantid.

comment:27 Changed 6 years ago by Martyn Gigg

Some users, who occasionally take the develop builds, have also seen this. I have tracked it down to line 1053 of AxesDialog.cpp. The member variable m_grpFramed does not seem to be created any longer but it is still added to the layout on line 1053. Does the variable just need removing?

comment:28 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Fixed crash when opening axis dialog

Refs #8198

Changeset: f6518ba1b2da08091155fa87f5a786d514c99a2f

comment:29 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:30 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:31 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8198_axisdialog_ui_improvements'

Full changeset: 3534eb3935866725a777fc8e695d5e0dd16aa6b4

comment:32 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9043

Note: See TracTickets for help on using tickets.