Ticket #8206 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[ICAT] Checkbox selection

Reported by: Jay Rainey Owned by: Jay Rainey
Priority: critical Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Jay Rainey) (diff)

In #7637 Owen noted that the:

Checkboxes cannot be directly selected on the mac.

I have tested this on Windows and Linux, and it appears that they cannot be selected directly there either.

Change History

comment:1 Changed 7 years ago by Jay Rainey

  • Summary changed from Improve selection ICAT GUI to [ICAT] Improve checkbox selection

comment:2 Changed 7 years ago by Jay Rainey

  • Status changed from new to inprogress

Allow user to select checkboxes. Refs #8206.

  • Removed unused mouse event.
  • Added two slots. One for when the user selects a row (or many) and one for when they check a checkbox.

Changeset: a406137a3232d568ebde4bcf8ad0c7405a02c4e1

comment:3 Changed 7 years ago by Jay Rainey

  • Priority changed from major to critical
  • Milestone changed from Release 3.1 to Release 3.0

comment:4 Changed 7 years ago by Jay Rainey

  • Description modified (diff)
  • Summary changed from [ICAT] Improve checkbox selection to [ICAT] Checkbox selection

It appears I got the tickets mixed up. I thought that this ticket was #8200. I have changed their summary/description so my changes now make sense.

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

The problem

It was not possible to select rows from the datafiles table using the related checkboxes. It worked fine when using the mouse and clicking the datafiles (this functionality should remain, and be tested too).

To test

  1. Open Mantid and log into the catalog with your federal ID.
  2. Perform a search.
  3. Select an investigation from the results.
  4. Select a datafile using the check-box and try to select multiple rows (using ctrl + left click or dragging your mouse).

If you can now select rows using the checkboxes then the changes made were correct. A short code review would be appreciated.

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 7 years ago by Martyn Gigg

The functionality now seems to work as a user would expect it to. The implementation looks fine and using the signals is far more intuitive & understandable than the event filter approach I think.

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8206_icat_checkbox_fix'

Full changeset: ​94efd4278ab21a892afe9d5099aa9195cd0031e3

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9051

Note: See TracTickets for help on using tickets.