Ticket #8213 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Zero entry logs can cause a crash

Reported by: Nick Draper Owned by: Nick Draper
Priority: critical Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

After this 

rnum=28511

Load(str(rnum),OutputWorkspace=str(rnum),LoadMonitors='1')

ws=mtd[str(rnum)]
r= ws.getRun()
time_array = r.getLogData("proton_charge").times
value_array = r.getLogData("proton_charge").value

FilterByLogValue(str(rnum),'Theta',0.295,0.305,OutputWorkspace=str(rnum)+"_03deg")
Rebin(str(rnum)+"_03deg","5.0,20.0,100000.0",PreserveEvents=0,OutputWorkspace=str(rnum)+"_03deg_Hist")

selcting a log can led to an uncaught exception

Change History

comment:1 Changed 7 years ago by Nick Draper

TESTER:

The error occurs when clicking on a zero entry time series log value that is numeric. Use the script above and check that this doesn't crash anymore.

comment:2 Changed 7 years ago by Nick Draper

re #8123 prevent crash by returning NaN

Changeset: 0528b49b09da010c42f81f1e6bc489c329814554

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

It does not crash any more. And it is in agreement with the others Log Statistics (Min, Max, Median, Mean, StdDev).

comment:6 Changed 7 years ago by Gesner Passos

Merge remote-tracking branch 'origin/feature/8213_Dont_crash_with_empty_logs'

Full changeset: ​e84ac70dafc375f76328ea0f4fc79ebb727964d8

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9058

Note: See TracTickets for help on using tickets.