Ticket #8222 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Enable LoadPreNexus to handle bad event index in pulse ID file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

Pulse ID file can have some event ID in pulse ID file. They might be some veto message or some other special signal. LoadEventPreNexus cannot handle this type of exception. It is a disastrous situation for event filtering.

Attachments

verify8222.cpp​ (463 bytes) - added by Wenduo Zhou 7 years ago.
verify8222b.py​ (605 bytes) - added by Wenduo Zhou 7 years ago.
verify8222a.py​ (606 bytes) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:2 Changed 7 years ago by Wenduo Zhou

  • Blocked By 8291 added

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Enabled to treat veto pulses. Refs #8222.

  1. Enabled to unmask event indexes with veto flag.

(unmaskVetoEventIndex)

  1. Clean the codes
  1. Fixed a bug to set the ordering flag of event lists.

Changeset: 60482f08cb72082109dc33e57032f95170e3959d

comment:6 Changed 7 years ago by Wenduo Zhou

  • Milestone changed from Backlog to Release 3.2

comment:7 Changed 7 years ago by Wenduo Zhou

Removed some disabled codes. Refs #8222.

Changeset: 0b78a1780eae5c47a8db8953055e762bfdb14b67

comment:8 Changed 7 years ago by Wenduo Zhou

For tester

As the data used is a VULCAN run, which is not in system test, it is better for a developer from SNS to test it.

  1. Before merging the change from this ticket, edit ../Mantid/Framework/DataObjects/src/EventList.cpp at line 1282 as verify8222.cpp. This is because there is a bug in LoadEventPreNexus2 to disable RebinByPulseTime to sort events by pulse time.
  1. Build Mantid in master, download script verify8222a.py and run the script. Take a look at final output workspace "V20002_PP0_Rebin".
  1. Clean the change you just made. Merge the change from this ticket and rebuild Mantid
  1. Download and run script verify8222b.py. You can compare current "V20002_PP0_Rebin" and the previous one. The different comes fro that all vetoed pulse/event indexes are set to a correct value with the change of this ticket.

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:9 Changed 7 years ago by Wenduo Zhou

  • Blocked By 8291 removed

comment:10 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:12 Changed 7 years ago by Wenduo Zhou

Changed output workspace class type. Refs #8222.

Changeset: 206bf019e09610f45592373a848087f913bcee4f

comment:13 Changed 7 years ago by Wenduo Zhou

Lowered the confidence for using version 2. Refs #8222.

Changeset: c992b94248b5484c17354044dbb4c52f87bd8bfa

comment:14 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8222_preNexus_veto'

Full changeset: ​4658e8d2be0e20c24d7115f2797741b9722a524f

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9067

Note: See TracTickets for help on using tickets.