Ticket #8226 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

The live data algorithms cannot handle multiperiod event data

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description


Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Changes to LoadLiveData to handle workspace groups. Re #8226.

Changeset: f6570572fe1393b6a7826cfa9d549803d0dd4ac0

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:4 Changed 7 years ago by Russell Taylor

Sorry for the delay with this - things kept coming up. I will get to it ASAP.

comment:5 Changed 7 years ago by Russell Taylor

If I'm understanding all this correctly, these changes are required because setting a WorkspaceGroup pointer on an algorithm does not work if the workspace is not in the ADS (see #6257).

Ideally, this problem should be solved in a general way rather than making changes for the specific case of live data. How critical is it that this gets in? Can it wait a little for us to figure out a nicer fix?

On a related note, I don't understand why ISIS are continuing with an unchanged concept of periods for event data. Since you can use the period log to assign every event to a specific period, it doesn't to me make sense to bake it into the loading process. It can be done at any time via the filtering algorithms.

comment:6 Changed 7 years ago by Russell Taylor

Parking for a bit while we figure out whether this can be done in a more general way via WorkspaceProperty.

comment:7 Changed 7 years ago by Russell Taylor

Clearly, no more general method of dealing with this will happen before the release, so I'll test this work this week and things can be revisited later.

comment:8 Changed 7 years ago by Russell Taylor

As with all tickets, there really ought to be some instructions on how to test. So far, just about everything I've tried as crashed MantidPlot.

comment:9 Changed 7 years ago by Roman Tolchenov

That was a good test. What did you try?

comment:10 Changed 7 years ago by Roman Tolchenov

Changes to LoadLiveData to handle workspace groups. Re #8226.

Changeset: 9f677b27f7a2c7dd22b5c15cbb60b77160acd810

comment:11 Changed 7 years ago by Roman Tolchenov

Merged master into this branch to include fixes from other tickets. These may stop the crashes.

Test

Build MantidPlot with the changes (feature/8226_multiperiod_live_event_data) in debug mode to expose ISISLiveEventDataListener to the LiveData interface. Start FakeISISEventDAE and FakeISISHistoDAE algorithms. NPeriods and NSpectra properties must be the same in both algorithms. Set NPeriods > 1. Open LiveData interface and select ISISLiveEventDataListener. The non-zero data should be in 100-200 ms region.

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8226_multiperiod_live_event_data'

Full changeset: ​d76dbb79d1f71b609adc8c331925a38a9bffb187

comment:13 Changed 7 years ago by Russell Taylor

Let this in for now so that the functionality is there, but created ticket #8856 to remove the code in LoadLiveData once #6257 is done.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9071

Note: See TracTickets for help on using tickets.