Ticket #8241 (closed: fixed)
IntegratePeaksMD does not need CoordinatesToUse
Reported by: | Owen Arnold | Owned by: | Vickie Lynch |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Karl Palmen |
Description
If would be best if this option was removed altogether.
I'm not sure we have the concept of a depreciated property (we do for whole algorithms), but this might be the most useful way of avoiding breakages and ensuring backwards compatibility.
Change History
comment:2 Changed 7 years ago by Vickie Lynch
- Status changed from new to inprogress
Refs #8241 new versions
Changeset: fd9787ed5507e26d8ad823af3dff95e5f2b50f61
comment:3 Changed 7 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
Test that CoordinatesToUse is not a property of new versions of CentroidPeaksMD or IntegratePeaksMD
comment:5 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:6 Changed 7 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
Merger problem with ReduceSCD_OneRun.py .
comment:7 Changed 7 years ago by Vickie Lynch
- Status changed from reopened to inprogress
Refs #8241 do not change ReduceOneSCD_Run.py
Changeset: 364a91880bcad98adc6079b12f622c09c1ebff9a
comment:8 Changed 7 years ago by Vickie Lynch
Refs #8241 new versions
Changeset: 84587983601e21bf26e62d293f39f1149e5cc5ad
comment:9 Changed 7 years ago by Vickie Lynch
Refs #8241 do not change ReduceOneSCD_Run.py
Changeset: 66e3bc783c4e4087fdc4c87833249a5a28553e41
comment:10 Changed 7 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
Russell help me rebase so there should not be a conflict this time
comment:12 Changed 7 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8241_RemoveCoordinatesToUse'
Full changeset: 9253bac7d982c9600b27d589d631b218e4513a65
comment:13 Changed 7 years ago by Vickie Lynch
Refs #8241 new versions
Changeset: fd9787ed5507e26d8ad823af3dff95e5f2b50f61
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9086
One approach here would be as follows: