Ticket #8244 (closed: fixed)
[ICAT] Date selector issues
| Reported by: | Samuel Jackson | Owned by: | Jay Rainey |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | GUI | Keywords: | ICAT,ICAT4 |
| Cc: | Blocked By: | #8152, #8274, #8322 | |
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Jay Rainey) (diff)
A few issues from testing ticket #6457:
- I can't select today as a valid date option. This is definitely wrong.
- The start and end date selectors seem to randomly become disabled for some reason.
- I can select a start date that more recent than the end date.
Change History
comment:2 Changed 7 years ago by Jay Rainey
- Keywords ICAT,ICAT4 added
- Milestone changed from Backlog to Release 3.1
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from new to inprogress
Date selection and enabled buttons. Refs #8244.
- The user can now select today from the calendar.
- I have removed the enable/disable functionality of the not used date picker.
Changeset: 53982f2f79236781339e88eff80be582b596fbf4
comment:5 Changed 7 years ago by Jay Rainey
In regards to point 3, I could throw a runtime error (as was the case in ICat3), but I think a better approach would be to create a red error star (*) with related tooltip to explain to the user what went wrong, as is the case for other error messages on the GUI. That's what #8152 is blocking.
comment:7 Changed 7 years ago by Jay Rainey
Start date cannot be greater than end. Refs #8244.
Changeset: b37a1ec74efe57e718a09893d9a85694f4f3eb78
comment:8 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/master' into feature/8244_icat_date_selector_issues. Refs #8244.
Conflicts:
- Code/Mantid/MantidQt/MantidWidgets/inc/MantidQtMantidWidgets/ICatSearch2.h
- Code/Mantid/MantidQt/MantidWidgets/src/ICatSearch2.cpp
Changeset: 67b3a8724a28f14fab661c84f711f7a643c5f067
comment:9 Changed 7 years ago by Jay Rainey
Merge branch 'feature/8244_icat_date_selector_issues' into develop. Refs #8244.
Conflicts:
- Code/Mantid/MantidQt/MantidWidgets/src/CatalogSearch.cpp
Changeset: 048fbb56fa0ee3148448311914ea3721a24ddba2
comment:10 Changed 7 years ago by Jay Rainey
Prepend catalog helper. Refs #8244.
Changeset: 4fa5f1c2d3fd4c3fa53fbe6b5aba4b82b71569e6
comment:11 Changed 7 years ago by Jay Rainey
- Blocked By 8322 added
comment:14 Changed 7 years ago by Jay Rainey
To test
- Open Mantid & log into the catalog.
- Click "Search" from the menu, and then click the [...] icon beside Start or End date. The calendar will open.
- Try to select today as a date. This should now be possible.
- Ensure the start and end date selectors no longer "randomly" become disabled.
- Select a start date that is greater than an end date. A red error icon (*) should appear with the related error message.
comment:15 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/master' into feature/8244_icat_date_selector_issues. Refs #8244.
Conflicts:
Code/Mantid/MantidQt/MantidWidgets/src/CatalogSearch.cpp
Changeset: 605cac423ed00388b7638a48de09ea162f6d2d57
comment:16 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
comment:18 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:19 Changed 7 years ago by Roman Tolchenov
Works as described
comment:20 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8244_icat_date_selector_issues'
Full changeset: c79d1dda53d83b4d2145f3be4854f05e69f66255
comment:21 Changed 7 years ago by Jay Rainey
Merge branch 'feature/8244_icat_date_selector_issues' into develop. Refs #8244.
Conflicts:
Code/Mantid/MantidQt/MantidWidgets/src/CatalogSearch.cpp
Changeset: 048fbb56fa0ee3148448311914ea3721a24ddba2
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9089
