Ticket #8248 (closed: fixed)
Remove monitor colours on transposed data
Reported by: | Keith Brown | Owned by: | Keith Brown |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.0 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description
The new Monitor highlighting added in #3726 is good for most cases, but it becomes wrong when the workspace is transposed.
Nick and I came to the conclusion that if the data is transposed, the monitors shouldn't be highlighted.
The following script should reproduce this:
import offspec as nr binning=["2.0","-0.05","10.0","2"] sec=nr.nrCalcSEConst("0.5","55.0") nr.nrSESANSP0Fn("28516-28535:2","P0Average","108","120","2","1",binning,diagnostics="1") rstart=28516 for i in range(58,88,3): sec=nr.nrCalcSEConst("0.5",str(i)) #nr.nrSESANSP0Fn(str(rstart),"P0"+str(i),"108","120","2","1",binning,diagnostics="1") nr.nrSESANSFn(str(rstart+1),"PMB_PMMA_06_"+str(i),"","P0Averagepol","108","120","2","1","2",str(sec),binning,"2","0") Transpose("PMB_PMMA_06_"+str(i)+"2dSESANS",OutputWorkspace="PMB_PMMA_06_"+str(i)+"2dSESANS_Tr") CropWorkspace("PMB_PMMA_06_"+str(i)+"2dSESANS_Tr",75,150,OutputWorkspace="PMB_PMMA_06_"+str(i)+"2dSESANS_Tr") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"2ddet") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"2dnorm") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"2dpol") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"norm") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"pol") DeleteWorkspace("PMB_PMMA_06_"+str(i)+"SESANS") rstart=rstart+2
Change History
comment:4 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
Nick said this could make it into the release as it was a rather small fix, assuming it passes testing:
to Tester
Load any workspace. View the data. You should see the cream highlighted monitors. Run Transpose on the workspace Load the transposed data. The cream highlights shouldn't appear.
comment:5 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:6 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8248_monitor_colours_on_transposed_data'
Full changeset: 770067bb5c5033de3eedd34775636bd3d3a96d31
Refs #8248 checkMontorCache now checks the axis
Added a check into checkMontorCache to see if the Axis that is ususally the Spectra Axis is still the Spectra Axis. This check should only return false if the workspace has been transposed.
Changeset: 4c0834f7d1e47b6b478f5d678bab146c9f455587