Ticket #8250 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ExtractMaskToTable problems

Reported by: Vickie Lynch Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

Get this error without Xmin and Xmax: 

Error in execution of algorithm ExtractMaskToTable:
XMin or XMax cannot be empty.  XMin must be less than XMax.

What is MaskTableWorkspace an input? Hint for OutputWorkspace says to give a list of detector IDs. It does work but is confusing.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8250. Multidetector quick test.

Uses combine combine multi features and division by correction algorithm rather than by transmission workspaces.

Changeset: 9efd16309e51c94105c9c2781bdc1d7ba6741ae6

comment:2 Changed 7 years ago by Wenduo Zhou

Modified wiki and some comments. Refs #8250.

Changeset: 0c1bea8ce9a81e350197b9450081568413e294c3

comment:3 Changed 7 years ago by Wenduo Zhou

Cleaned the code. Refs #8250.

Changeset: 03db7510fb9501c79c3b3d4d62c800961f5551da

comment:4 Changed 7 years ago by Wenduo Zhou

Resolved conflict. Refs #8250.

Conflicts:

Code/Mantid/Framework/Algorithms/src/ExtractMaskToTable.cpp

Changeset: 00d6ecd65e0754e45a6015b0c9237c434d54e1dd

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

I discussed with Peter and agreed that it is best to have an explicit input for Xmin and Xmax. Therefore, there will be no real change to this algorithm.

On the other hand, in order to reduce the confusion, the algorithm's wiki was modified.

comment:6 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:7 Changed 7 years ago by Karl Palmen

The heading for the InputWorkspace section has unbalanced equals signs, causing one equal sign to appear in the heading.

The grammar for the cases in lines 59 and 73 of the unit test is not quite correct. Line 59 has a 'item' instead 'items', but could be reworded like line 44. Line 73 needs 'larger' instead of 'large'.

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Corrected gramma error. Refs #8250.

Changeset: c89bd78b275b1b1f3c17dae110d3a601e781c42e

comment:10 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Andrei Savici

comment:12 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The Xmin and Xmax values appear as optional in the help

comment:13 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to verify
  • Resolution set to fixed

Wiki is modified to make Xmin and Xmax as Mandatory.

comment:14 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester changed from Andrei Savici to Vickie Lynch

comment:15 Changed 7 years ago by Vickie Lynch

Refs #8250 fix merge conflict

Changeset: 101c7f53e608b95fe21eb154ef4e7cb844bc7667

comment:16 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Detector ids in table are right

comment:17 Changed 7 years ago by Wenduo Zhou

Resolved conflict. Refs #8250.

Conflicts:

Code/Mantid/Framework/Algorithms/src/ExtractMaskToTable.cpp

Changeset: 00d6ecd65e0754e45a6015b0c9237c434d54e1dd

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9095

Note: See TracTickets for help on using tickets.