Ticket #8257 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SplatterPlot not locked with MDHistoWorkspaces in VSI

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: blocker Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The SplatterPlot mode does not seem to be reliably locked out when using the scale plugin and having a original MDHistoWorkspace (either workspace or via rebinner plugin) on view switching. This opens up the possibility to crash Mantid using the SplatterPlot mode on a disallowed workspace type.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #8257. Adding better lockout finding.

Changeset: d2b1cc50e779acf65c4ebca8ded11367b5832fff

comment:3 Changed 7 years ago by Michael Reuter

Refs #8257. Adding better lockout finding.

Changeset: 678129877c506625428ef6e8a20c2b694c5f7eab

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To Test (do each separately):

  • MDEventWorkspace
    1. Load a MDEventWorkspace file into Mantid, and open the workspace in the VSI
    2. Apply a rebinner, adjust the parameters and apply.
    3. Apply a scale plugin, adjust the parameters and apply.
    4. Switch to another view.
  • MDHistoWorkspace
    1. Load a MDHistoWorkspace file into Mantid, and open the workspace in the VSI
    2. Apply a scale plugin, adjust the parameters and apply.
    3. Switch to another view.

In both cases, the SplatterPlot view mode button should remain disabled after switching views. It may be seen to briefly enable itself, but after the view is switched and drawn, it should be disabled.

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8257_splatterplot_lockout'

Full changeset: ​6fb0a5314fd1d5d1692fb13f62d80763f507ad11

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9102

Note: See TracTickets for help on using tickets.