Ticket #8260 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ResampleX with negative values

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

Since TOPAZ has negative time-of-flight in its data, this algorithm consumes all of the system memory while generating the axis. The algorithm should check for the condition and throw an exception.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8260. Use EventWorkspace->setAllX when possible.

Changeset: f354a4368aea4ce6d288c75043685c268e67c98b

comment:2 Changed 7 years ago by Peter Peterson

Merge branch 'bugfix/8260_negative_resamplex' into develop

Re #8260

Conflicts:

Code/Mantid/Framework/Algorithms/CMakeLists.txt Code/Mantid/Framework/ICat/src/ICat4/ICat4Catalog.cpp

Changeset: 921e3f426151dab5cf194acb6eb7dd1810d0df96

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​bugfix/8260_negative_resamplex.

To test: Since this is problem specifically with TOPAZ you're best off trying with their data.

  1. Load live pre-nexus data: /SNS/TOPAZ/shared/live/TOPAZ_something_live_neutron_event.dat
  2. ResampleX on that workspace

The memory should now be much more contained.

Warning: If you want to see the bug, be prepared to kill mantid as it goes over 64GB of memory without sign of slowing.

comment:4 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:5 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8260_negative_resamplex'

Full changeset: ​932639b2b4debc3f0c2d2e1ea7428e782b3a9d17

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9105

Note: See TracTickets for help on using tickets.