Ticket #8272 (closed: fixed)
A couple of code doc changes to loadmcstas
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | torben.nielsen@… | Blocked By: | |
Blocking: | Tester: | Karl Palmen |
Description
Torben writes:
Derudover er der 2 slå fejl som kan rettes en gang når du/vi får tid: LoacMcStasTest.h linje 25 skal være: Test checks if number getNumberHistograms = 2x4096. (64x64= 4096 pixels in one detector)
Dvs. så er regnestykket på 8192 pixels mere sigende.
LoadMcStas.cpp linje 7 skal være LoadMcStas can be used for reading McStas 2.1 histogram and event data. Dvs. event var stavet forkert. (evnet –>event )
Change History
comment:2 Changed 7 years ago by Anders Markvardsen
- Status changed from new to inprogress
Doc changes to loadmcstas. re #8272
Changeset: 329b36f8aef125160f5e4a3de2eb4801bddebfc6
comment:3 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
check that
- LoacMcStasTest.h linje 25 now reads:
Test checks if number getNumberHistograms = 2x4096. (64x64= 4096 pixels in one detector)
- LoadMcStas.cpp linje now reads: LoadMcStas can be used for reading McStas 2.1 histogram and event data.
comment:4 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:5 Changed 7 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
The only change is the correction of the line
"LoadMcStas can be used for reading McStas 2.1 histogram and event data." in the wiki statement.
Line 25 of the unit test reads "Test checks if number getNumberHistograms = 327682x16384. (128x128= 16384 pixels in one detector)", which is different than what is required in part 1 of the test described above.
comment:7 Changed 7 years ago by Anders Markvardsen
remaining code doc for this ticket. re #8272
Changeset: 0a058c9b235e252db85619c7f51a69884fa5113a
comment:8 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
Karl thanks for spotting this. To test see description above
comment:10 Changed 7 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
It needs a checkbuild done before testing can be done.
comment:11 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to verify
- Resolution set to fixed
Checkbuild done. To test see description above
comment:13 Changed 7 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8272_doc_change_loadmcstas'
Full changeset: 26086e389cf9d12f2efa887cfce294f89a024626
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9117
Torben writes:
#xyzw: Deleting redundant lines in LoadMcStas.cpp
It looks like line 333 – 334 can be deleted.