Ticket #8275 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MUON: Error reported when loading multiple runs.

Reported by: Peter Parker Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.0
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Select, for example, MUSR as your instrument and try to load "48024-48025".

The following error is reported: 

File "<Interface>", line 3
SyntaxError: can't assign to operator
GroupWorkspaces started
Error in execution of algorithm GroupWorkspaces
Data Object search object MUSR00048024-5

This has been in Mantid since at least 2.5.3.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

This looks like an easy fix. The problem is in this piece of Python code: 

boevsMoreBoevs = CloneWorkspace(InputWorkspace='[..]')
MUSR00015189-92 = GroupWorkspaces(InputWorkspaces='[..],boevsMoreBoevs')

I am not really sure whether we really need python here, so replacing it with C++ GroupWorkspaces algorithm call should eliminate the problem and make the code cleaner.

However, I will look how far I can get on this one and if it turns out to be more difficult I will postpone the fix until the next release. The fact that it wasn't reported by anybody since 2.5.3 leads to a though that this functionality is not heavily used.

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Refs #8275. Replaced Python with C++ for grouping workspaces.

Changeset: d2f8b7c05ea9bb5a125dd90184ca93d50c6f40d8

comment:3 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

Please make sure error is not thrown anymore and ranges are now correctly supported.

Additionally, please verify that everything is still grouped correctly. To do that just load various runs and run ranges and check that pairs/group workspaces are put to the right workspace groups.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:4 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:5 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8275_muon_ranges_error'

Full changeset: ​793d16df79773d0dc59472f526860961a1262592

comment:6 Changed 7 years ago by Peter Parker

Loading ranges appear to work fine now. Plotting run X, run Y, and both runs together show that the combination is the average of the two.

The "Group / Group Pair" drop-down options work for both single and multiple runs.

Getting rid of the unnecessary calls from Python was an improvement.

No errors or crashes.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9120

Note: See TracTickets for help on using tickets.