Ticket #8281 (closed: fixed)
[C2E] Tidy S(Q,w) interface.
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.2 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Parker |
Description
The S(Q,w) interface looks messy. Make some cosmetic changes to tidy it up. Swap the input widget to a data selector.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
Refs #8281 Hook up data selector widget to interface.
Changeset: 34eff7209ab47cede4f72e684a3ce35a81efdba1
comment:3 Changed 7 years ago by Samuel Jackson
Merge branch 'feature/8281_sqw_interface_tidy' into develop
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: 30d1d96016242c69c095eaa4db5588386c7508fa
comment:4 Changed 7 years ago by Martyn Gigg
Merge branch 'feature/8281_sqw_interface_tidy' into develop
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: 440233de7037d5a37e105d3ec902c2af11072c12
comment:6 Changed 7 years ago by Samuel Jackson
Refs #8281 Fix tab order for binning input on S(Q,w) interface.
Changeset: 8f7ddc3d6b02682ec147be54215556dce67f211c
comment:7 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
The changes in this ticket are mostly cosmetic. Go look at the S(Q,w) interface on Indirect Convert to Energy and check it still works. Check that the plot buttons still works too.
comment:8 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:9 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution fixed deleted
We've got another merge conflict on this one Sam, I'm passing it back for you to fix.
comment:10 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Merge remote-tracking branch 'origin/master' into feature/8281_sqw_interface_tidy
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: 64dfdf29399a87ebd674a3ca3883ea07ee16b296
comment:11 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
I merged in master this morning, so check it's finished building on Jenkins, then verify.
comment:12 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:13 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
comment:15 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution fixed deleted
Currently in develop but not in the branch:
https://github.com/mantidproject/mantid/commit/8f7ddc3d6b02682ec147be54215556dce67f211c
comment:16 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
comment:18 Changed 7 years ago by Peter Parker
- Status changed from verifying to reopened
- Resolution fixed deleted
The two points we discussed were:
- The energy fields are now much smaller than the Q fields, when they should get equal billing.
- The tab order should be able to skip from Q Low -> Q Width -> Q High -> E Low -> E Width -> E High.
Also, it's worth double-checking the help links for the tabs to make sure they point to http://www.mantidproject.org/Indirect:SofQW, etc.
comment:19 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #8281 Resize energy rebin widgets and fix tab order (again).
Changeset: 5c20207c4ccf6885af57199239104ada7deaad03
comment:20 Changed 7 years ago by Samuel Jackson
Merge branch 'feature/8281_sqw_interface_tidy' into develop
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: a93298eb66ae69bf936ae068c391fa6baef64f44
comment:21 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:23 Changed 7 years ago by Samuel Jackson
Merge branch 'master' of github.com:mantidproject/mantid into feature/8281_sqw_interface_tidy
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: bc4e086db8eb1c897da334c03f3f23cd8a608f9d
comment:24 Changed 7 years ago by Samuel Jackson
Merge branch 'feature/8281_sqw_interface_tidy' into develop
Refs #8281
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ConvertToEnergy.ui
Changeset: 669253350568a0be76d24befcfef6e80d259619d
comment:25 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge branch 'feature/8281_sqw_interface_tidy' of github.com:mantidproject/mantid into feature/8281_sqw_interface_tidy
Full changeset: c85239f9b6abc94cbc002db7d26afb28a3fc4e82
comment:26 Changed 7 years ago by Peter Parker
Merge remote-tracking branch 'origin/feature/8281_sqw_interface_tidy'
Full changeset: 44da0a17a010a99a4e6c78140d8686ebfef87398
comment:27 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9126
Refs #8281 Tidy up the S(Q,w) interface on C2E.
Changeset: 2f78d54c5a5cc3db89aecb781fe02a636532d6cd