Ticket #8286 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] ConvFit Delta Function error

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

I get the following output when using ConvFit with two lorentzians and a delta function. This is likely caused by building the fit function incorrectly for two lorentzians but could be something else. 

Fit type : Delta = True ; Lorentzians = 2
Background type : FitL
Fit func : name=LinearBackground,A0=0.000893564752624,A1=0.000850214158756;(composite=Convolution;name=Resolution, FileName="/home/chs18285/git/systemtests/logs/irs21360_graphite002_res.nxs";(name=DeltaFunction,Height=0.172843211319;name=Lorentzian,Amplitude=0.0132390405743,PeakCentre=0.00106075622697,HWHM=0.0341231851037;name=Lorentzian,Amplitude=-0.0655516749364,PeakCentre=0.00251811671829,HWHM=-0.0244123287437;ties=(f0.PeakCentre=f1.PeakCentre)))
ValueError: Invalid value for property Function (Function) "name=LinearBackground,A0=0.000893564752624,A1=0.000850214158756;(composite=Convolution;name=Resolution, FileName="/home/chs18285/git/systemtests/logs/irs21360_graphite002_res.nxs";(name=DeltaFunction,Height=0.172843211319;name=Lorentzian,Amplitude=0.0132390405743,PeakCentre=0.00106075622697,HWHM=0.0341231851037;name=Lorentzian,Amplitude=-0.0655516749364,PeakCentre=0.00251811671829,HWHM=-0.0244123287437;ties=(f0.PeakCentre=f1.PeakCentre)))": ParamFunction DeltaFunction does not have parameter (PeakCentre).
  at line 14 in '<Interface>'
  caused by line 216 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py'
  caused by line 115 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py'
  caused by line 186 in '/opt/Mantid/bin/mantid/simpleapi.py'

A similar issue (now fixed) was present in Mantid 2.6.1.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8286 Correct ties to refer to correct functions.

Changeset: a014192e415b9225e7249354b6aff30151e7482e

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

Run ConvFit with two lorentzians and check use delta function. You should no longer get the above error. Instructions on using the interface can be found here:

http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_ConvFit

comment:3 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.0

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8286_ConvFit_delta_func_error'

Full changeset: ​d6d10a3a53801c5f4a0957b19cd3499ab63aa934

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #8286 Use correct index when not using delta.

Changeset: 65ebfa9d210c149119de63a77083969630f411d3

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

Realised that the fix would break if user didn't use delta function.

To Tester: As above, but check both with and without using a delta function.

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Martyn Gigg

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8286_ConvFit_delta_func_error'

Full changeset: ​63dbc9eaf01cf9d2cb34f0cbf790be12616ed420

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9131

Note: See TracTickets for help on using tickets.