Ticket #8305 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix deprecated cast in VatesAPI

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: critical Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The class MedianAndBelowThresholdRange has a deprecated boost::shared_dynamic_cast. It should be changed to a boost::dynamic_pointer_cast.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #8305. Fixing cast.

Changeset: 0bf8aa6a414bd69de82d6f4156e769102d483c3d

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: This MUST be tested on Ubuntu 13.10 as is doesn't apply elsewhere. The current file doesn't compile so, apply the change and things should compile and run as before.

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8305_deprecated_cast'

Full changeset: ​59b96c2c6adc5b915d98dc61cb92b460baf9fd93

comment:6 Changed 7 years ago by Andrei Savici

It is a boost issue. Same problem would have been in 13.04, and Fedora 19

comment:7 Changed 7 years ago by Michael Reuter

OK. This keeps us ahead of the curve.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9150

Note: See TracTickets for help on using tickets.