Ticket #8308 (assigned)

Opened 7 years ago

Last modified 5 years ago

SystemTests for SANS2D

Reported by: Gesner Passos Owned by: Anton Piccardo-Selg
Priority: major Milestone: Backlog
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Peter Parker) (diff)

Original suggestion from Gesner:

I think the following systemtests should be added for SANS2D:

  • Normal reduction in batch mode
  • Copy of the single mode reduction and double check with the result in batch mode.
  • ADD a run twice and perform full reduction checking that the result is compatible with loading a run and applying the reduction to 2XRun.
  • Performing the reduction as in the single mode (GUI) twice produces the same result
  • Perform a full 2D reduction
  • Searching the centre

Perform all these tests for low angle and high angle detectors.

Misc suggestions from Gesner which you should sift through and interpret as you see fit. Some of these may not be necessary:

  • Transform #7643 and #8052 in systemtests
  • UnitTests for SANSUtility methods.
  • Add many SANS2D files
  • Monitor getLogData from SANS2D #7612
  • Multi period - check mult period files available
  • UnitTest for maskfile
  • Perform slicing and reduction.
  • Avoid error similar to #5942
  • Create a system test exposing the problem with long log run.

Richard has agreed to provide us with data (as small as possible) to cover the routes through the code that he feels are important. Do these first then consider whether further coverage is necessary based on Gesner's suggestions.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Description modified (diff)

comment:2 Changed 7 years ago by Gesner Passos

  • Blocked By 8313 added

comment:3 Changed 7 years ago by Gesner Passos

  • Blocked By 8341 added

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:5 Changed 7 years ago by Gesner Passos

Richard suggested for the High Angle bank, use the following data:

Try from cycle 12/2 with mask 122N attached

14273-add    14273-add    14253-add
14270-add    14270-add    14272-add    [yes this direct beam really is different to the other one]

In reduction tab set detectors to “merged” and fit “rescale” using Q =0.06 to 0.3, I get rescale=1.054,  leave shift fixed at zero.

There are still issues with the geometry and/or detector parralalax here, so the peak is not in the correct place yet on the front detector (see pdf plot). Iwas also messingaround with the direct beam files, so the  ones here are “experimental”, but will be fine for testing purposes.

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:7 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:8 Changed 6 years ago by Peter Parker

  • Blocked By 9367 added

comment:9 Changed 5 years ago by Peter Parker

  • Owner changed from Peter Parker to Anton Piccardo-Selg
  • Description modified (diff)
  • Blocked By 8313, 8341, 9367 removed

See updated ticket description, and ignore previous comment from Gesner.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9153

Note: See TracTickets for help on using tickets.